[ncl-talk] Buffer overflow in ymake-filter

Michael Kuhn michael.kuhn at informatik.uni-hamburg.de
Wed Sep 13 07:05:25 MDT 2017


Hi,

since updating to GCC 7, I noticed some sporadic errors when compiling
ncl. The problem comes from a buffer overflow in ymake-filter: The line
buffer is currently hardcoded to be 2048 bytes large but some Makefiles
contain lines longer than that. This caused the Makefiles to sometimes
not be generated, consequently failing parts of the build.

The attached patch replaces the static buffer with a dynamic one. It
starts out at 2048 bytes and grows by 1024 bytes at a time if required.


Best regards,
Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: ymake-filter.patch
Type: text/x-patch
Size: 575 bytes
Desc: not available
URL: <http://mailman.ucar.edu/pipermail/ncl-talk/attachments/20170913/ed4bf289/attachment.bin>


More information about the ncl-talk mailing list