[mpas-developers] Trunk Commit Check: Bug in core_sw/module_global_diagnostics.F

[Doug Jacobsen]

Hi Everyone,

So, I found a bug in the shallow waters module_global_diagnostics.F. It's
only apparent for limited area grids. Basically, I was getting cellsOnEdge,
and just using both of them, but on a boundaryEdge one of the two
cellsOnEdge is 0, making it not a valid cell, so the code would segfault. I
changed it to check that both of the two cells were not 0 before doing the
computation, and it appears to work.

I have attached the file, to see if anyone cared to look at it. I'll
probably commit it tomorrow if I don't hear anything back. Thanks!

Doug
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mailman.ucar.edu/pipermail/mpas-developers/attachments/20101220/345618cb/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: module_global_diagnostics.F
Type: text/x-fortran
Size: 17895 bytes
Desc: not available
Url : http://mailman.ucar.edu/pipermail/mpas-developers/attachments/20101220/345618cb/attachment.bin