[mpas-developers] bugfix to MPAS trunk
Michael Duda
duda at ucar.edu
Wed Apr 21 15:53:04 MDT 2010
Hi, All.
I'd like to make a couple of minor bug-fixes to the MPAS trunk,
specifically, in module_io_input.F and module_io_output.F. The
changes are pretty uncontroversial and were spotted by the g95
compiler.
In src/framework/module_io_input.F:
996,999c996,999
< real :: super_real0d
< real, dimension(:), pointer :: super_real1d
< real, dimension(:,:), pointer :: super_real2d
< real, dimension(:,:,:), pointer :: super_real3d
---
> real (kind=RKIND) :: super_real0d
> real (kind=RKIND), dimension(:), pointer :: super_real1d
> real (kind=RKIND), dimension(:,:), pointer :: super_real2d
> real (kind=RKIND), dimension(:,:,:), pointer :: super_real3d
In src/framework/module_io_output.F:
129,131c129,131
< real, dimension(:), pointer :: super_real1d
< real, dimension(:,:), pointer :: super_real2d
< real, dimension(:,:,:), pointer :: super_real3d
---
> real (kind=RKIND), dimension(:), pointer :: super_real1d
> real (kind=RKIND), dimension(:,:), pointer :: super_real2d
> real (kind=RKIND), dimension(:,:,:), pointer :: super_real3d
Also, since it does do a good job at spotting non-standard Fortran
and other potential errors, I'd like to add make targets for g95.
In Makefile:
83a84,106
> g95:
> ( make all \
> "FC = mpif90" \
> "CC = mpicc" \
> "SFC = g95" \
> "SCC = gcc" \
> "FFLAGS = -O3 -ffree-line-length-huge" \
> "CFLAGS = -O3" \
> "LDFLAGS = -O3" \
> "CORE = $(CORE)" \
> "CPPFLAGS = -DRKIND=8 $(MODEL_FORMULATION) $(EXPAND_LEVELS) -D_MPI -DUNDERSCORE $(FILE_OFFSET) $(ZOLTAN_DEFINE)" )
>
> g95-serial:
> ( make all \
> "FC = g95" \
> "CC = gcc" \
> "SFC = g95" \
> "SCC = gcc" \
> "FFLAGS = -O3 -ffree-line-length-huge" \
> "CFLAGS = -O3" \
> "LDFLAGS = -O3" \
> "CORE = $(CORE)" \
> "CPPFLAGS = -DRKIND=8 $(MODEL_FORMULATION) $(EXPAND_LEVELS) -DUNDERSCORE $(FILE_OFFSET) $(ZOLTAN_DEFINE)" )
If there are no objections, I'll go ahead and commit these to the
repository trunk.
Cheers,
Michael
More information about the mpas-developers
mailing list