[Dart-dev] DART/branches Revision: 12780

[dart at ucar.edu]

hendric at ucar.edu
2018-08-22 14:59:06 -0600 (Wed, 22 Aug 2018)
52

updating branch to be in synch with the rma_trunk




Index: DART/branches/rma_distrib
===================================================================
--- DART/branches/rma_distrib	2018-08-14 17:02:38 UTC (rev 12779)
+++ DART/branches/rma_distrib	2018-08-22 20:59:06 UTC (rev 12780)

Property changes on: DART/branches/rma_distrib
___________________________________________________________________
Modified: svn:mergeinfo
## -41,7 +41,7 ##
 /DART/branches/rma_sprint:8095-8166
 /DART/branches/rma_state_structure_test_dir:9472-9676
 /DART/branches/rma_state_structure_unit_test:9691-10268
-/DART/branches/rma_trunk:12423-12766
+/DART/branches/rma_trunk:12423-12779
 /DART/branches/rma_trunk_clamping:8786-8801
 /DART/branches/rma_trunk_filename:8011-8157
 /DART/branches/rma_trunk_get_state_fun:8568-8596
Modified: DART/branches/rma_distrib/CHANGELOG
===================================================================
--- DART/branches/rma_distrib/CHANGELOG	2018-08-14 17:02:38 UTC (rev 12779)
+++ DART/branches/rma_distrib/CHANGELOG	2018-08-22 20:59:06 UTC (rev 12780)
@@ -771,9 +771,33 @@
 - Added more functions to the netcdf_utilities_mod.f90
 
 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
++ Aug 03 2018 :: performance fix for distributed mean          Revision: 12758
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
+
+- Important performance fix if model does vertical conversion for localization.
+Results were not wrong but performance was poor if 'distribute_mean = .true.'
+was selected in the &assim_tools_nml namelist.
+Now distributing the mean runs in close to the non-distributed time and uses
+much less memory for large models. This only impacts models which do a vertical
+conversion of either the observation or state vertical coordinate for localization
+AND which set &assim_tools_nml :: distribute_mean = .true. to use less memory.
+When using a distributed mean "convert_all_obs_verticals_first = .true." should
+be set.  If your observations will impact most of the model state, then
+"convert_all_state_verticals_first = .true.' can also be set.
+
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 + MMM DD YYYY :: summary of next changes                    $Revision$
 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 
+- fix for WRF's wind direction vectors when using the Polar Stereographic 
+  map projection.  Thanks to Kevin Manning for the fix.
+
+- removed 'allow_missing_in_clm' flag from the &assim_tools_nml namelist in
+  the CICE work directory.  The flag moved to a different namelist and the
+  CICE model doesn't care about it.
+
+- increased the maximum number of input files to obs_diag from 100 to 10000.
+
 # <next few lines under version control, do not edit>
 # $URL$
 # $Revision$

Modified: DART/branches/rma_distrib/assimilation_code/programs/obs_diag/threed_sphere/obs_diag.f90
===================================================================
--- DART/branches/rma_distrib/assimilation_code/programs/obs_diag/threed_sphere/obs_diag.f90	2018-08-14 17:02:38 UTC (rev 12779)
+++ DART/branches/rma_distrib/assimilation_code/programs/obs_diag/threed_sphere/obs_diag.f90	2018-08-22 20:59:06 UTC (rev 12780)
@@ -32,7 +32,8 @@
                              get_last_obs, destroy_obs, get_num_qc, get_qc_meta_data
 use      obs_def_mod, only : obs_def_type, get_obs_def_error_variance, get_obs_def_time, &
                              get_obs_def_location,  get_obs_def_type_of_obs
-use     obs_kind_mod, only : max_defined_types_of_obs, get_quantity_for_type_of_obs, get_name_for_type_of_obs, &
+use     obs_kind_mod, only : max_defined_types_of_obs, get_quantity_for_type_of_obs, &
+                             get_name_for_type_of_obs, &
                              QTY_U_WIND_COMPONENT, QTY_V_WIND_COMPONENT
 use     location_mod, only : location_type, get_location, set_location_missing,   &
                              write_location, operator(/=), is_location_in_region, &
@@ -171,7 +172,7 @@
 integer, parameter, dimension(2) ::    good_poste_qcs = (/ 0, 1       /)
 integer :: numqcvals
 
-integer, parameter :: max_num_input_files = 100
+integer, parameter :: max_num_input_files = 10000
 
 !>@todo remove after verifying NbiqQC, NbadIZ not used in plotting scripts
 real(r8):: rat_cri               = 5000.0_r8 ! QC ratio
@@ -3528,9 +3529,10 @@
 
 
 subroutine WriteNetCDF(fname)
+
 character(len=*), intent(in) :: fname
 
-integer :: ncid, i, nobs, typesdimlen
+integer :: ncid, i, nobs, typesdimlen, io
 integer ::  RegionDimID,  RegionVarID
 integer ::  MlevelDimID,  MlevelVarID
 integer ::  PlevelDimID,  PlevelVarID
@@ -3657,15 +3659,14 @@
 
 FILEloop : do i = 1, num_input_files
 
-  write(string1,'(''obs_seq_file_'',i3.3)')i
-  call nc_check(nf90_put_att(ncid, NF90_GLOBAL, &
-         trim(string1), trim(obs_sequence_name(i)) ), &
-         'WriteNetCDF', 'region_names:obs_kinds')
+  write(string1,'(''obs_seq_file_'',i5.5)')i
+  io = nf90_put_att(ncid, NF90_GLOBAL, trim(string1), trim(obs_sequence_name(i)))