[Dart-dev] DART/branches Revision: 12150

[dart at ucar.edu]

nancy at ucar.edu
2017-11-29 13:50:01 -0700 (Wed, 29 Nov 2017)
171
updates from johnny - filled in the use statements, adding
routine names as local parameters inside routines, removing
unused variables and adding doxygen where missing.




Modified: DART/branches/recam/models/cam-fv/model_mod.f90
===================================================================
--- DART/branches/recam/models/cam-fv/model_mod.f90	2017-11-29 00:06:54 UTC (rev 12149)
+++ DART/branches/recam/models/cam-fv/model_mod.f90	2017-11-29 20:50:01 UTC (rev 12150)
@@ -15,21 +15,32 @@
 !>@todo fixme fill in the actual names we use after we've gotten
 !>further into writing the coded
 
-use             types_mod
-use      time_manager_mod
+use             types_mod, only : MISSING_R8, MISSING_I, i8, r8, vtablenamelength, &
+                                  gravity  
+use      time_manager_mod, only : set_time, time_type, set_date, &
+                                  set_calendar_type, get_date
 use          location_mod, only : location_type, set_vertical, set_location, &
                                   get_location,get_close_obs, get_close_state, & 
-                                  query_location, &
                                   VERTISUNDEF, VERTISSURFACE, VERTISLEVEL, &
                                   VERTISPRESSURE, VERTISHEIGHT, &
-                                  VERTISSCALEHEIGHT
-use         utilities_mod
-use          obs_kind_mod
-use     mpi_utilities_mod
-use        random_seq_mod
-use  ensemble_manager_mod
-use distributed_state_mod
-use   state_structure_mod
+                                  VERTISSCALEHEIGHT, query_location
+use         utilities_mod, only : find_namelist_in_file, check_namelist_read, &
+                                  string_to_logical, string_to_real,& 
+                                  logfileunit, do_nml_file, do_nml_term, &
+                                  register_module, error_handler, &
+                                  file_exist, to_upper, E_ERR, E_MSG
+use          obs_kind_mod, only : QTY_SURFACE_ELEVATION, QTY_PRESSURE, &
+                                  QTY_GEOMETRIC_HEIGHT, QTY_VERTLEVEL, QTY_SURFACE_PRESSURE, &
+                                  QTY_TEMPERATURE, QTY_SPECIFIC_HUMIDITY, &
+                                  get_index_for_quantity, get_num_quantities
+!#! use     mpi_utilities_mod
+!#! use        random_seq_mod
+use  ensemble_manager_mod,  only : ensemble_type
+use distributed_state_mod,  only : get_state
+use   state_structure_mod,  only : add_domain, get_dart_vector_index, get_domain_size, &
+                                   get_dim_name, get_kind_index, get_num_dims, &
+                                   get_num_variables, get_varid_from_kind, &
+                                   get_model_variable_indices, state_structure_info
 use  netcdf_utilities_mod,  only : nc_get_variable, nc_get_variable_size, &
                                    nc_add_attribute_to_variable, &
                                    nc_define_integer_variable, &
@@ -39,8 +50,13 @@
                                    nc_define_dimension, nc_put_variable, &
                                    nc_sync, nc_enddef, nc_redef, nc_open_readonly, &
                                    nc_close, nc_variable_exists
-use       location_io_mod
-use        quad_utils_mod
+!#!use       location_io_mod
+use        quad_utils_mod,  only : quad_interp_handle, init_quad_interp, &
+                                   set_quad_coords, &! finalize_quad_interp, &
+                                   !>@todo FIXME need to call finalize_quad_interp
+                                   quad_lon_lat_locate, quad_lon_lat_evaluate, &
+                                   GRID_QUAD_IRREG_SPACED_REGULAR,  &
+                                   QUAD_LOCATED_CELL_CENTERS
 use     default_model_mod,  only : adv_1step, init_time, init_conditions, &
                                    nc_write_model_vars, pert_model_copies
 
@@ -117,7 +133,7 @@
 
 
 ! global variables
-character(len=512) :: string1, string2, string3
+character(len=512) :: string1, string2
 logical, save      :: module_initialized = .false.
 
 ! domain id for the cam model.  this allows us access to all of the state structure
@@ -201,7 +217,6 @@
 subroutine static_init_model()
 
 integer :: iunit, io
-integer :: ncid
 integer :: nfields
 
 if ( module_initialized ) return
@@ -479,16 +494,17 @@
 real(r8),           intent(out) :: interp_vals(ens_size) !< array of interpolated values
 integer,            intent(out) :: istatus(ens_size)
 
+character(len=*), parameter :: routine = 'model_interpolate:'
+
 integer  :: varid
 integer  :: lon_bot, lat_bot, lon_top, lat_top
 real(r8) :: lon_fract, lat_fract
 real(r8) :: lon_lat_vert(3), botvals(ens_size), topvals(ens_size)
 integer  :: level_one_array(ens_size)
-integer  :: which_vert, status1, status2, status_array(ens_size)
+integer  :: which_vert, status1, status_array(ens_size)
 type(quad_interp_handle) :: interp_handle
-integer  :: ijk(3), icorner, imember, numdims
+integer  :: icorner, numdims
 integer  :: four_lons(4), four_lats(4)
-integer  :: two_bots(2), two_tops(2)
 real(r8) :: two_horiz_fracts(2)
 integer  :: four_bot_levs(4, ens_size), four_top_levs(4, ens_size)