[Dart-dev] DART/branches Revision: 11605

[dart at ucar.edu]

nancy at ucar.edu
2017-05-04 16:16:16 -0600 (Thu, 04 May 2017)
173
i was using 'allow_any_impact_value' in the tool
and 'allow_any_impact_values' in assim_tools.
standardize on the plural version.  update the
docs and nml to match.  sigh.




Modified: DART/branches/model_mod_changes/assimilation_code/modules/utilities/obs_impact_mod.f90
===================================================================
--- DART/branches/model_mod_changes/assimilation_code/modules/utilities/obs_impact_mod.f90	2017-05-04 22:14:53 UTC (rev 11604)
+++ DART/branches/model_mod_changes/assimilation_code/modules/utilities/obs_impact_mod.f90	2017-05-04 22:16:16 UTC (rev 11605)
@@ -119,7 +119,7 @@
 ! namelist: input/output names, values, etc
 character(len=512) :: input_filename  = ''
 character(len=512) :: output_filename = ''
-logical :: allow_any_impact_value = .false.
+logical :: allow_any_impact_values = .false.
 logical :: debug = .false.  ! .true. for more output
 
 ! namelist
@@ -126,7 +126,7 @@
 namelist /obs_impact_tool_nml/  &
    input_filename,  &
    output_filename, &
-   allow_any_impact_value, &
+   allow_any_impact_values, &
    debug
 
 contains
@@ -377,7 +377,7 @@
          call error_handler(E_ERR, 'obs_impact', &
                            'impact values must be between 0 and 1, inclusive', &
                            source, revision, revdate, text2=readbuf, &
-                           text3='set "allow_any_impact_value=.true." in namelist to allow')
+                           text3='set "allow_any_impact_values=.true." in namelist to allow')
       endif
    endif
 endif
@@ -1459,12 +1459,12 @@
 
 ! FIXME: do this at runtime now.  if you want to check values
 ! at table build time, uncomment this code again.
-!if (.not. allow_any_factor_value) then
+!if (.not. allow_any_impact_values) then
 !   if (rvalue < 0.0_r8 .or. rvalue > 1.0_r8) then 
 !      call error_handler(E_ERR, 'check_impact_line', &
 !                        'impact values must be between 0 and 1, inclusive', &
 !                        source, revision, revdate, text2=readbuf, &
-!                        text3='set "allow_any_factor_value=.true." in namelist to allow')
+!                        text3='set "allow_any_impact_values=.true." in namelist to allow')
 !   endif
 !endif
 

Modified: DART/branches/model_mod_changes/assimilation_code/programs/obs_impact_tool/obs_impact_tool.html
===================================================================
--- DART/branches/model_mod_changes/assimilation_code/programs/obs_impact_tool/obs_impact_tool.html	2017-05-04 22:14:53 UTC (rev 11604)
+++ DART/branches/model_mod_changes/assimilation_code/programs/obs_impact_tool/obs_impact_tool.html	2017-05-04 22:16:16 UTC (rev 11605)
@@ -163,9 +163,10 @@
 <div class=namelist>
 <pre>
 &amp;obs_impact_tool_nml
-  input_filename         = 'cross_correlations.txt'
-  output_filename        = 'control_impact_runtime.txt'
-  debug                  = .true.
+  input_filename          = 'cross_correlations.txt'
+  output_filename         = 'control_impact_runtime.txt'
+  allow_any_impact_values = .false.
+  debug                   = .true.
   /
 </pre>
 </div>
@@ -201,6 +202,14 @@
 the file.
 </TD></TR>
 
+<TR><TD>allow_any_impact_values</TD>
+    <TD>logical</TD>
+    <TD>Recommended to stay false.  This allows only 0.0 and 1.0 as the
+impact factors, effectively using the full increments or no increments
+during the assimilation.  To experiment with partial application of
+the increments this flag can be set to true to allow other values.
+<TD></TR>
+
 <TR><TD>debug</TD>
     <TD>logical</TD>
     <TD>If true print out debugging info.

Modified: DART/branches/model_mod_changes/assimilation_code/programs/obs_impact_tool/obs_impact_tool.nml
===================================================================
--- DART/branches/model_mod_changes/assimilation_code/programs/obs_impact_tool/obs_impact_tool.nml	2017-05-04 22:14:53 UTC (rev 11604)
+++ DART/branches/model_mod_changes/assimilation_code/programs/obs_impact_tool/obs_impact_tool.nml	2017-05-04 22:16:16 UTC (rev 11605)
@@ -1,6 +1,6 @@
 &obs_impact_tool_nml
-  input_filename         = 'cross_correlations.txt'
-  output_filename        = 'control_impact_runtime.txt'
-  allow_any_factor_value = .false.
-  debug                  = .false.
+  input_filename          = 'cross_correlations.txt'
+  output_filename         = 'control_impact_runtime.txt'
+  allow_any_impact_values = .false.
+  debug                   = .false.
   /