[Dart-dev] DART/branches Revision: 11897

[dart at ucar.edu]

thoar at ucar.edu
2017-08-10 09:27:32 -0600 (Thu, 10 Aug 2017)
72
removed unused variables, general code cleanup to improve readability.




Modified: DART/branches/coamps/assimilation_code/modules/io/state_structure_mod.f90
===================================================================
--- DART/branches/coamps/assimilation_code/modules/io/state_structure_mod.f90	2017-08-09 23:16:36 UTC (rev 11896)
+++ DART/branches/coamps/assimilation_code/modules/io/state_structure_mod.f90	2017-08-10 15:27:32 UTC (rev 11897)
@@ -1157,6 +1157,7 @@
 !-------------------------------------------------------------------------------
 !> Adding space for an unlimited dimension in the dimesion arrays
 !> The unlimited dimension needs to be last in the list for def_var
+!>@todo this is a terrible name. The unlimited dimension can be for anything, not just time.
 
 
 subroutine add_time_unlimited(unlimited_dimId)
@@ -1163,7 +1164,7 @@
 
 integer, intent(in)  :: unlimited_dimId
 
-call error_handler(E_ERR, 'add_time_unlimited', 'does not exist')
+call error_handler(E_ERR, 'add_time_unlimited', 'routine does not exist')
 
 end subroutine add_time_unlimited
 

Modified: DART/branches/coamps/assimilation_code/modules/utilities/utilities_mod.f90
===================================================================
--- DART/branches/coamps/assimilation_code/modules/utilities/utilities_mod.f90	2017-08-09 23:16:36 UTC (rev 11896)
+++ DART/branches/coamps/assimilation_code/modules/utilities/utilities_mod.f90	2017-08-10 15:27:32 UTC (rev 11897)
@@ -980,9 +980,9 @@
    integer,          intent(out), optional :: return_rc
    integer  :: iunit
 
-   integer           :: nc, rc, rlen
+   integer           :: rc, rlen
    logical           :: open, use_recl
-   character(len=32) :: format, pos, act, stat, acc, conversion, recl, del
+   character(len=32) :: format, pos, act, stat, acc, conversion, del
 
    if ( .not. module_initialized ) call initialize_utilities
 

Modified: DART/branches/coamps/models/coamps_nest/coamps_domain_mod.f90
===================================================================
--- DART/branches/coamps/models/coamps_nest/coamps_domain_mod.f90	2017-08-09 23:16:36 UTC (rev 11896)
+++ DART/branches/coamps/models/coamps_nest/coamps_domain_mod.f90	2017-08-10 15:27:32 UTC (rev 11897)
@@ -605,7 +605,6 @@
 
       real(kind=r8)               :: u_tmp(SINGLE_POINT, SINGLE_POINT)
       real(kind=r8)               :: v_tmp(SINGLE_POINT, SINGLE_POINT)
-      character(len=90)           :: uvstr
 
       u_tmp(SINGLE_POINT, SINGLE_POINT) = u_wind
       v_tmp(SINGLE_POINT, SINGLE_POINT) = v_wind

Modified: DART/branches/coamps/models/coamps_nest/coamps_interp_mod.f90
===================================================================
--- DART/branches/coamps/models/coamps_nest/coamps_interp_mod.f90	2017-08-09 23:16:36 UTC (rev 11896)
+++ DART/branches/coamps/models/coamps_nest/coamps_interp_mod.f90	2017-08-10 15:27:32 UTC (rev 11897)
@@ -33,16 +33,16 @@
 
     use coamps_statevec_mod,  only : state_vector, find_state_variable
 
-    use coamps_intrinsic_mod, only : s2pint,                         &
-                                     sfcp,                           &
-                                     utom,                           &
-                                     vtom,                           &
-                                     vor,                            &
+    use coamps_intrinsic_mod, only : s2pint,  &
+                                     sfcp,    &
+                                     utom,    &
+                                     vtom,    &
+                                     vor,     &
                                      z2zint
 
-    use coamps_util_mod,      only : check_alloc_status,             &
-                                     check_dealloc_status,           &
-                                     trace_message,           &
+    use coamps_util_mod,      only : check_alloc_status,   &
+                                     check_dealloc_status, &
+                                     trace_message,        &
                                      print_label_name
   
     use location_mod,         only : location_type,    &
@@ -89,11 +89,11 @@
     ! BEGIN TYPES AND CONSTANTS 
     !------------------------------
   
-  ! Atmospheric constants - specific heat, gas constant (dry air),
-  ! and the initial pressure for calculating the Exner function
-  real(kind=r8), parameter :: R   = real(287.0,  kind=r8)
-  real(kind=r8), parameter :: Cp  = real(1004.0, kind=r8)
-  real(kind=r8), parameter :: P00 = real(1000.0, kind=r8)
+    ! Atmospheric constants - specific heat, gas constant (dry air),
+    ! and the initial pressure for calculating the Exner function
+    real(kind=r8), parameter :: R   = real(287.0,  kind=r8)
+    real(kind=r8), parameter :: Cp  = real(1004.0, kind=r8)
+    real(kind=r8), parameter :: P00 = real(1000.0, kind=r8)
 
     ! Set below-ground levels as "missing" in the vertical interpolation
     integer, parameter :: USE_MISSING_VALUE = 1
@@ -247,6 +247,8 @@
     integer :: cur_availability_index