[Dart-dev] DART/branches Revision: 11491

[dart at ucar.edu]

nancy at ucar.edu
2017-04-14 10:38:47 -0600 (Fri, 14 Apr 2017)
50
update 2 comments and add  FIXME to one of them.




Modified: DART/branches/rma_trunk/assimilation_code/modules/utilities/mpi_utilities_mod.f90
===================================================================
--- DART/branches/rma_trunk/assimilation_code/modules/utilities/mpi_utilities_mod.f90	2017-04-14 16:31:53 UTC (rev 11490)
+++ DART/branches/rma_trunk/assimilation_code/modules/utilities/mpi_utilities_mod.f90	2017-04-14 16:38:47 UTC (rev 11491)
@@ -1869,7 +1869,7 @@
 
 !-----------------------------------------------------------------------------
 !-----------------------------------------------------------------------------
-! Collect min and max on task. This is for adaptive_inflate_mod
+! Collect min and max on task.
 subroutine send_minmax_to(minmax, task, global_val)
 
 real(r8), intent(in)  :: minmax(2) !> min max on each task
@@ -1919,7 +1919,7 @@
    call error_handler(E_ERR,'broadcast_minmax', errstring, source, revision, revdate)
 endif
 
-! why can't we just use datasize in a single call, like the code above?
+!>@todo FIXME shouldn't this use datasize in a single call, like the code above?
 !   call mpi_allreduce(MPI_IN_PLACE, min_var, num_elements, datasize, MPI_MIN, get_dart_mpi_comm(), errcode)
 !   call mpi_allreduce(MPI_IN_PLACE, max_var, num_elements, datasize, MPI_MAX, get_dart_mpi_comm(), errcode)