[Dart-dev] DART/branches Revision: 10761

[dart at ucar.edu]

thoar at ucar.edu
2016-11-17 20:51:03 -0700 (Thu, 17 Nov 2016)
479
test_cf_conventions now compiles and runs partway through 
(after you "ncgen -o simple.nc simeple1.cdl"), but surely 
doesn't perform the right tests.  I hacked it pretty severely 
to get it to compile to test the other modules.

The other files had their comments doxygenized (if they weren't already)
and a bit of the style guide was enforced. Some unused variables 
were removed when they were never going to be used again. Others left 
if they were in commented-out blocks.




Modified: DART/branches/rma_fixed_filenames/filter/filter_mod.f90
===================================================================
--- DART/branches/rma_fixed_filenames/filter/filter_mod.f90	2016-11-17 18:44:38 UTC (rev 10760)
+++ DART/branches/rma_fixed_filenames/filter/filter_mod.f90	2016-11-18 03:51:03 UTC (rev 10761)
@@ -96,13 +96,14 @@
 character(len=128), parameter :: revdate  = "$Date$"
 
 ! Some convenient global storage items
-character(len=129)      :: msgstring
+character(len=512)      :: msgstring
 type(obs_type)          :: observation
 
 integer                 :: trace_level, timestamp_level
 
 ! Defining whether diagnostics are for prior or posterior
 integer, parameter :: PRIOR_DIAG = 0, POSTERIOR_DIAG = 2
+
 ! Maximum number of domains. This is arbitrarily set based on 
 ! the maximum number of domains in WRF.  
 integer, parameter :: MAX_NUM_DOMS = 10
@@ -138,8 +139,8 @@
 
 ! IO options
 ! Name of files containing a list of {input,output} restart files, 1 file per domain
-character(len=512) :: input_restart_file_list(MAX_NUM_DOMS)  = 'null'  
-character(len=512) :: output_restart_file_list(MAX_NUM_DOMS) = 'null'
+character(len=256) :: input_restart_file_list(MAX_NUM_DOMS)  = 'null'  
+character(len=256) :: output_restart_file_list(MAX_NUM_DOMS) = 'null'
 ! Read in a single file and perturb this to create an ensemble
 logical            :: perturb_from_single_instance = .false.
 real(r8)           :: perturbation_amplitude       = 0.2_r8
@@ -147,9 +148,9 @@
 logical            :: single_file_in               = .false. ! all copies read from 1 file
 logical            :: single_file_out              = .false. ! all copies written to 1 file
 
-character(len = 129) :: obs_sequence_in_name  = "obs_seq.out",    &
-                        obs_sequence_out_name = "obs_seq.final",  &
-                        adv_ens_command       = './advance_model.csh'
+character(len=256) :: obs_sequence_in_name  = "obs_seq.out",    &
+                      obs_sequence_out_name = "obs_seq.final",  &
+                      adv_ens_command       = './advance_model.csh'
 
 !                  == './advance_model.csh'    -> advance ensemble using a script
 
@@ -171,18 +172,19 @@
 real(r8)             :: inf_upper_bound(2)        = 1000000.0_r8
 real(r8)             :: inf_sd_lower_bound(2)     = 0.0_r8
 
-namelist /filter_nml/ async, adv_ens_command, ens_size, tasks_per_model_advance,    &
+namelist /filter_nml/ async, adv_ens_command, ens_size, &
+   tasks_per_model_advance, &
    obs_sequence_in_name, obs_sequence_out_name, &
-   init_time_days, init_time_seconds,  &
-   first_obs_days, first_obs_seconds, last_obs_days, last_obs_seconds,              &
+   init_time_days, init_time_seconds, &
+   first_obs_days, first_obs_seconds, last_obs_days, last_obs_seconds, &
    obs_window_days, obs_window_seconds, &
-   num_output_obs_members, output_restart_mean,           &
-   output_interval, num_groups, trace_execution,                 &
-   output_forward_op_errors, output_timestamps,                 &
-   inf_flavor, inf_initial_from_restart, inf_sd_initial_from_restart,               &
-   inf_deterministic, inf_damping,            &
+   num_output_obs_members, output_restart_mean, &
+   output_interval, num_groups, trace_execution, &
+   output_forward_op_errors, output_timestamps, &
+   inf_flavor, inf_initial_from_restart, inf_sd_initial_from_restart, &
+   inf_deterministic, inf_damping, &
    inf_initial, inf_sd_initial, &
-   inf_lower_bound, inf_upper_bound, inf_sd_lower_bound,           &
+   inf_lower_bound, inf_upper_bound, inf_sd_lower_bound, &
    silence, output_restart_file_list, &
    distributed_state, input_restart_file_list, &
    single_file_in, single_file_out, &
@@ -1029,9 +1031,9 @@
 integer,                 intent(out)   :: in_obs_copy, obs_val_index
 integer,                 intent(out)   :: input_qc_index, DART_qc_index
 
-character(len = metadatalength) :: no_qc_meta_data = 'No incoming data QC'
-character(len = metadatalength) :: dqc_meta_data   = 'DART quality control'
-character(len = 129) :: obs_seq_read_format
+character(len=metadatalength) :: no_qc_meta_data = 'No incoming data QC'
+character(len=metadatalength) :: dqc_meta_data   = 'DART quality control'
+character(len=129) :: obs_seq_read_format
 integer              :: obs_seq_file_id, num_obs_copies
 integer              :: tnum_copies, tnum_qc, tnum_obs, tmax_num_obs, qc_num_inc, num_qc
 logical              :: pre_I_format

Modified: DART/branches/rma_fixed_filenames/io/copies_on_off_mod.f90
===================================================================
--- DART/branches/rma_fixed_filenames/io/copies_on_off_mod.f90	2016-11-17 18:44:38 UTC (rev 10760)
+++ DART/branches/rma_fixed_filenames/io/copies_on_off_mod.f90	2016-11-18 03:51:03 UTC (rev 10761)
@@ -5,6 +5,7 @@
 ! $Id$
 
 module copies_on_off_mod
+
 !> \defgroup copies_on_off_mod copies_on_off_mod
 !> @{
 !> @brief IO storage module
@@ -115,8 +116,11 @@