[Dart-dev] DART/branches Revision: 10854

[dart at ucar.edu]

thoar at ucar.edu
2016-12-30 10:21:03 -0700 (Fri, 30 Dec 2016)
135
Fixing a bug in the level4_to_obs.f90 converter.
Had incorrectly converted latent heat flux obs as sensible heat obs 
and vice-versa.




Modified: DART/branches/Tb/observations/Ameriflux/level4_to_obs.f90
===================================================================
--- DART/branches/Tb/observations/Ameriflux/level4_to_obs.f90	2016-12-29 19:11:46 UTC (rev 10853)
+++ DART/branches/Tb/observations/Ameriflux/level4_to_obs.f90	2016-12-30 17:21:03 UTC (rev 10854)
@@ -144,7 +144,6 @@
 
 write(string1, *) 'tower located at lat, lon, elev  =', latitude, longitude, elevation
 write(string2, *) 'flux observations taken at       =', flux_height,'m'
-
 if (verbose) call error_handler(E_MSG,'level4_to_obs',string1,text2=string2)
 
 ! check the lat/lon values to see if they are ok
@@ -263,7 +262,7 @@
       oerr = 10.0_r8 + abs(tower%h)*0.22_r8
       qc   = real(tower%hQC,r8)
       call create_3d_obs(latitude, longitude, flux_height, VERTISHEIGHT, tower%h, &
-                         TOWER_LATENT_HEAT_FLUX, oerr, oday, osec, qc, obs)
+                         TOWER_SENSIBLE_HEAT_FLUX, oerr, oday, osec, qc, obs)
       call add_obs_to_seq(obs_seq, obs, tower%time_obs, prev_obs, prev_time, first_obs)
    endif
 
@@ -271,7 +270,7 @@
       oerr = 10.0_r8 + abs(tower%le)*0.32_r8
       qc   = real(tower%leQC,r8)
       call create_3d_obs(latitude, longitude, flux_height, VERTISHEIGHT, tower%le, &
-                         TOWER_SENSIBLE_HEAT_FLUX, oerr, oday, osec, qc, obs)
+                         TOWER_LATENT_HEAT_FLUX, oerr, oday, osec, qc, obs)
       call add_obs_to_seq(obs_seq, obs, tower%time_obs, prev_obs, prev_time, first_obs)
    endif
 
@@ -781,7 +780,7 @@
 ! - Rg_fqc         : global radiation quality flags:
 !                    0 = original, 1 = A (most reliable), 2 = B (medium), 3 = C (least reliable).
 !                    (Refer to Reichstein et al. 2005 Global Change Biology )
-! - Ta_f           : air temperature filled [C]
+! - Ta_f           : air temperature filled [°C]
 ! - Ta_fqc         : air temperature quality flags:
 !                    0 = original, 1 = A (most reliable), 2 = B (medium), 3 = C (least reliable).
 !                    (Refer to Reichstein et al. 2005 Global Change Biology )
@@ -789,7 +788,7 @@
 ! - VPD_fqc        : vapour pressure deficit quality flags:
 !                    0 = original, 1 = A (most reliable), 2 = B (medium), 3 = C (least reliable).
 !                    (Refer to Reichstein et al. 2005 Global Change Biology )
-! - Ts_f           : soil temperature filled [C]
+! - Ts_f           : soil temperature filled [°C]
 ! - Ts_fqc         : soil temperature quality flags:
 !                    0 = original, 1 = A (most reliable), 2 = B (medium), 3 = C (least reliable).
 !                    (Refer to Reichstein et al. 2005 Global Change Biology )

Modified: DART/branches/Tb/observations/Ameriflux/level4_to_obs.html
===================================================================
--- DART/branches/Tb/observations/Ameriflux/level4_to_obs.html	2016-12-29 19:11:46 UTC (rev 10853)
+++ DART/branches/Tb/observations/Ameriflux/level4_to_obs.html	2016-12-30 17:21:03 UTC (rev 10854)
@@ -53,6 +53,12 @@
 <a href="http://ameriflux.lbl.gov">http://ameriflux.lbl.gov</a>.
 </P>
 
+<H4>Notice</H4>
+<P>There was a pretty severe bug in the converter that swapped latent heat 
+   flux and sensible heat flux. The bug was present through revision 7200.
+   It has been corrected in all subsequent versions.
+</P>
+
 <P>
 The workflow is usually: 
 </P>

Modified: DART/branches/Tb/observations/Ameriflux/work/quickbuild.csh
===================================================================
--- DART/branches/Tb/observations/Ameriflux/work/quickbuild.csh	2016-12-29 19:11:46 UTC (rev 10853)
+++ DART/branches/Tb/observations/Ameriflux/work/quickbuild.csh	2016-12-30 17:21:03 UTC (rev 10854)
@@ -19,7 +19,7 @@
 \rm -f ../../../obs_def/obs_def_mod.f90
 \rm -f ../../../obs_kind/obs_kind_mod.f90
 
-set MODEL = "text converters"
+set MODEL = "Ameriflux converters"
 
 @ n = 1
 

Modified: DART/branches/rma_trunk/observations/Ameriflux/level4_to_obs.f90
===================================================================
--- DART/branches/rma_trunk/observations/Ameriflux/level4_to_obs.f90	2016-12-29 19:11:46 UTC (rev 10853)
+++ DART/branches/rma_trunk/observations/Ameriflux/level4_to_obs.f90	2016-12-30 17:21:03 UTC (rev 10854)
@@ -144,7 +144,6 @@
 
 write(string1, *) 'tower located at lat, lon, elev  =', latitude, longitude, elevation
 write(string2, *) 'flux observations taken at       =', flux_height,'m'
-
 if (verbose) call error_handler(E_MSG,'level4_to_obs',string1,text2=string2)
 
 ! check the lat/lon values to see if they are ok
@@ -263,7 +262,7 @@
       oerr = 10.0_r8 + abs(tower%h)*0.22_r8
       qc   = real(tower%hQC,r8)
       call create_3d_obs(latitude, longitude, flux_height, VERTISHEIGHT, tower%h, &
-                         TOWER_LATENT_HEAT_FLUX, oerr, oday, osec, qc, obs)
+                         TOWER_SENSIBLE_HEAT_FLUX, oerr, oday, osec, qc, obs)
       call add_obs_to_seq(obs_seq, obs, tower%time_obs, prev_obs, prev_time, first_obs)
    endif