[Dart-dev] [4387] DART/trunk/filter: Now that the mpi finalize routine calls the utility finalize routine,

[nancy at ucar.edu]

Revision: 4387
Author:   nancy
Date:     2010-06-04 11:53:16 -0600 (Fri, 04 Jun 2010)
Log Message:
-----------
Now that the mpi finalize routine calls the utility finalize routine,
no need to call the timestamp with the 'end' keyword from filter.

Modified Paths:
--------------
    DART/trunk/filter/filter.dopplerfold.f90
    DART/trunk/filter/filter.f90

-------------- next part --------------
Modified: DART/trunk/filter/filter.dopplerfold.f90
===================================================================
--- DART/trunk/filter/filter.dopplerfold.f90	2010-06-04 17:44:56 UTC (rev 4386)
+++ DART/trunk/filter/filter.dopplerfold.f90	2010-06-04 17:53:16 UTC (rev 4387)
@@ -290,7 +290,7 @@
    call smoother_read_restart(ens_handle, ens_size, model_size, time1, init_time_days)
 endif
 
-call timestamp_message('After  reading in ensemble restart filess')
+call timestamp_message('After  reading in ensemble restart files')
 call     trace_message('After  reading in ensemble restart files')
 
 call trace_message('Before initializing inflation')
@@ -771,19 +771,13 @@
    write(logfileunit,*)
 endif
 
-! Master task must close the log file; the magic 'end'
-! flag does that in the timestamp routine.
-! FIXME: when i commit the updated util mod, remove this line.
-! finalize_utilities() will write the final timestamp.
-if(my_task_id() == 0) call timestamp(source,revision,revdate,'end')
-
 ! YOU CAN NO LONGER WRITE TO THE LOG FILE BELOW THIS!
 ! After the call to finalize below, you cannot write to
 ! any fortran unit number.
 
 ! Make this the very last thing done, especially for SGI systems.
-! It shuts down MPI, and if you try to write after that, they can
-! can discard output that is written after mpi is finalized, or 
+! It shuts down MPI and if you try to write after that, some libraries
+! choose to discard output that is written after mpi is finalized, or 
 ! worse, the processes can hang.
 call finalize_mpi_utilities(async=async)
 

Modified: DART/trunk/filter/filter.f90
===================================================================
--- DART/trunk/filter/filter.f90	2010-06-04 17:44:56 UTC (rev 4386)
+++ DART/trunk/filter/filter.f90	2010-06-04 17:53:16 UTC (rev 4387)
@@ -766,19 +766,13 @@
    write(logfileunit,*)
 endif
 
-! Master task must close the log file; the magic 'end'
-! flag does that in the timestamp routine.
-! FIXME: when i commit the updated util mod, remove this line.
-! finalize_utilities() will write the final timestamp.
-if(my_task_id() == 0) call timestamp(source,revision,revdate,'end')
-
 ! YOU CAN NO LONGER WRITE TO THE LOG FILE BELOW THIS!
 ! After the call to finalize below, you cannot write to
 ! any fortran unit number.
 
 ! Make this the very last thing done, especially for SGI systems.
-! It shuts down MPI, and if you try to write after that, they can
-! can discard output that is written after mpi is finalized, or 
+! It shuts down MPI and if you try to write after that, some libraries
+! choose to discard output that is written after mpi is finalized, or 
 ! worse, the processes can hang.
 call finalize_mpi_utilities(async=async)