[Dart-dev] [3815] DART/trunk: Simply cleaning up unused variables, 'tabs' ( an extension to the F90 standard)
nancy at ucar.edu
nancy at ucar.edu
Wed Apr 15 22:00:45 MDT 2009
An HTML attachment was scrubbed...
URL: http://mailman.ucar.edu/pipermail/dart-dev/attachments/20090415/732bd58f/attachment-0001.html
-------------- next part --------------
Modified: DART/trunk/assim_tools/assim_tools_mod.f90
===================================================================
--- DART/trunk/assim_tools/assim_tools_mod.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/assim_tools/assim_tools_mod.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -1596,9 +1596,9 @@
real(r8) :: new_mean_left, new_mean_right, prod_weight_left, prod_weight_right
real(r8) :: new_var_left, new_var_right, new_sd_left, new_sd_right
real(r8) :: new_ens(ens_size), mass_sum
-real(r8) :: x(ens_size), sort_inc(ens_size)
+real(r8) :: x(ens_size)
real(r8) :: like_dense(2:ens_size), height(2:ens_size)
-real(r8) :: dist_to_first, dist_to_last, dist_for_unit_sd
+real(r8) :: dist_for_unit_sd
real(r8) :: a, b, c, hright, hleft, r1, r2, adj_r1, adj_r2
! Do an index sort of the ensemble members; Will want to do this very efficiently
Modified: DART/trunk/models/wrf/WRF_BC/pert_wrf_bc.f90
===================================================================
--- DART/trunk/models/wrf/WRF_BC/pert_wrf_bc.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/models/wrf/WRF_BC/pert_wrf_bc.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -83,8 +83,6 @@
real(r8) :: bdyfrq_old, bdyfrq, dtnext
-integer :: io, iunit
-
!----------------------------------------------------------------------
call initialize_utilities('pert_wrf_bc')
Modified: DART/trunk/models/wrf/WRF_BC/update_wrf_bc.f90
===================================================================
--- DART/trunk/models/wrf/WRF_BC/update_wrf_bc.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/models/wrf/WRF_BC/update_wrf_bc.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -82,8 +82,6 @@
real(r8) :: bdyfrq_old, bdyfrq, infl
-integer :: io, iunit
-
!----------------------------------------------------------------------
call initialize_utilities('update_wrf_bc')
Modified: DART/trunk/models/wrf/WRF_DART_utilities/dart_to_wrf.f90
===================================================================
--- DART/trunk/models/wrf/WRF_DART_utilities/dart_to_wrf.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/models/wrf/WRF_DART_utilities/dart_to_wrf.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -85,9 +85,7 @@
type(time_type) :: dart_time(2)
integer :: number_dart_values, ndays, &
year, month, day, hour, minute, second
-integer :: ndims, idims(2), dimids(2)
-integer :: i, ivtype, ind, dart_ind, my_index
-character(len=80) :: varname
+integer :: ind, dart_ind, my_index
character(len=19) :: timestring
character(len=1) :: idom
@@ -244,7 +242,7 @@
my_index = wrf%dom(id)%var_index_list(ind)
if ( debug ) then
- write(*,*),'Rolling up variable ',trim(wrf_state_variables(1,my_index))
+ write(*,*)'Rolling up variable ',trim(wrf_state_variables(1,my_index))
endif
! get stagger and variable size
@@ -255,8 +253,8 @@
if ( wrf%dom(id)%var_size(3,ind) == 1 ) then
if ( debug ) then
- write(*,*),trim(wrf_state_variables(1,my_index)),' is 2D'
- write(*,*),'size ',wrf%dom(id)%var_size(:,ind)
+ write(*,*)trim(wrf_state_variables(1,my_index)),' is 2D'
+ write(*,*)'size ',wrf%dom(id)%var_size(:,ind)
endif
allocate(wrf_var_2d(wrf%dom(id)%var_size(1,ind),wrf%dom(id)%var_size(2,ind)))
@@ -275,8 +273,8 @@
else
if ( debug ) then
- write(*,*),trim(wrf_state_variables(1,my_index)),' is 3D'
- write(*,*),'size ',wrf%dom(id)%var_size(:,ind)
+ write(*,*)trim(wrf_state_variables(1,my_index)),' is 3D'
+ write(*,*)'size ',wrf%dom(id)%var_size(:,ind)
endif
allocate(wrf_var_3d(wrf%dom(id)%var_size(1,ind),wrf%dom(id)%var_size(2,ind),wrf%dom(id)%var_size(3,ind)))
@@ -302,7 +300,7 @@
trim(wrf_state_variables(1,my_index)) == 'QCLOUD' ) then
if ( debug ) then
- write(*,*),'Setting 0 lower bound on ', &
+ write(*,*)'Setting 0 lower bound on ', &
trim(wrf_state_variables(1,my_index))
endif
Modified: DART/trunk/models/wrf/WRF_DART_utilities/ensemble_init.f90
===================================================================
--- DART/trunk/models/wrf/WRF_DART_utilities/ensemble_init.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/models/wrf/WRF_DART_utilities/ensemble_init.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -77,7 +77,6 @@
logical :: h_diab = .false.
character(len = 72) :: adv_mod_command = './wrf.exe'
real (kind=r8) :: center_search_half_length = 500000.0_r8
-integer :: center_search_half_size
integer :: center_spline_grid_scale = 10
integer :: vert_localization_coord = VERTISHEIGHT
! Allow (or not) observations above the surface but below the lowest
Modified: DART/trunk/models/wrf/WRF_DART_utilities/wrf_to_dart.f90
===================================================================
--- DART/trunk/models/wrf/WRF_DART_utilities/wrf_to_dart.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/models/wrf/WRF_DART_utilities/wrf_to_dart.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -83,7 +83,7 @@
real(r8), pointer :: dart(:)
real(r8), allocatable :: wrf_var_3d(:,:,:), wrf_var_2d(:,:)
type(time_type) :: dart_time(2)
-integer :: number_dart_values, ndays, &
+integer :: number_dart_values, &
year, month, day, hour, minute, second
integer :: ndims, idims(2), dimids(2)
integer :: i, ivtype, ind, dart_ind, my_index
Modified: DART/trunk/models/wrf/model_mod.f90
===================================================================
--- DART/trunk/models/wrf/model_mod.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/models/wrf/model_mod.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -258,10 +258,9 @@
integer :: ncid
integer :: io, iunit
-character (len=80) :: name
character (len=1) :: idom
logical, parameter :: debug = .false.
-integer :: var_id, ind, i, j, k, id, dart_index, model_type
+integer :: ind, i, j, k, id, dart_index
integer :: my_index
integer :: var_element_list(max_state_variables)
@@ -502,8 +501,9 @@
my_index = wrf%dom(id)%var_index_list(ind)
if ( debug ) then
- write(*,*),'Assigning dart vector indices for var_type ',wrf%dom(id)%var_type(ind)
- write(*,*),'affiliated with WRF variable ',trim(wrf_state_variables(1,my_index)),' of size ',wrf%dom(id)%var_size(:,ind)
+ write(*,*)'Assigning dart vector indices for var_type ',wrf%dom(id)%var_type(ind)
+ write(*,*)'affiliated with WRF variable ', &
+ trim(wrf_state_variables(1,my_index)),' of size ',wrf%dom(id)%var_size(:,ind)
endif
wrf%dom(id)%var_index(1,ind) = dart_index
@@ -518,7 +518,7 @@
enddo
wrf%dom(id)%var_index(2,ind) = dart_index - 1
- if ( debug ) write(*,*),'assigned start, stop ',wrf%dom(id)%var_index(:,ind)
+ if ( debug ) write(*,*)'assigned start, stop ',wrf%dom(id)%var_index(:,ind)
enddo ! loop through all viable state variables on this domain
@@ -528,7 +528,7 @@
wrf%model_size = dart_index - 1
allocate (ens_mean(wrf%model_size))
-if(debug) write(*,*) ' wrf model size is ',wrf%model_size
+if(debug) write(*,*)' wrf model size is ',wrf%model_size
end subroutine static_init_model
@@ -3318,7 +3318,7 @@
call nc_check(nf90_def_var(ncid=ncFileID, name="RAINNC_d0"//idom, xtype=nf90_real, &
dimids = (/ weDimID(id), snDimID(id), MemberDimID, unlimitedDimID /), &
- varid = var_id),'nc_write_model_atts','def_var RAINNC_d0'//idom)
+ varid = var_id),'nc_write_model_atts','def_var RAINNC_d0'//idom)
call nc_check(nf90_put_att(ncFileID, var_id, "units", "mm"), &
'nc_write_model_atts','put_att RAINNC_d0'//idom//' units')
call nc_check(nf90_put_att(ncFileID, var_id, "description", &
@@ -5934,7 +5934,7 @@
integer, intent(in) :: id
character(len=129), intent(in) :: state_table(num_state_table_columns,max_state_variables)
integer, intent(out), optional :: var_element_list(max_state_variables)
-integer :: ivar, num_vars, domain_int, i
+integer :: ivar, num_vars
character(len=129) :: my_string
logical :: debug = .false.
@@ -6016,7 +6016,7 @@
character(len=129),intent(out) :: stagger
logical, parameter :: debug = .false.
-integer :: var_id, strlen, ndims
+integer :: var_id, ndims
stagger = ''
call nc_check( nf90_inq_varid(ncid, trim(wrf_var_name), var_id), &
@@ -6125,7 +6125,7 @@
enddo ! ivar
- if ( debug ) write(*,*), 'get_type_from_ind ',trim(wrf_varname),' ',get_type_ind_from_type_string
+ if ( debug ) write(*,*)'get_type_from_ind ',trim(wrf_varname),' ',get_type_ind_from_type_string
return
Modified: DART/trunk/obs_def/obs_def_gps_mod.f90
===================================================================
--- DART/trunk/obs_def/obs_def_gps_mod.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/obs_def/obs_def_gps_mod.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -324,7 +324,6 @@
real(r8) :: nx, ny, nz, rfict0, ds, htop
character(len=6) :: subset0
-type(location_type) :: location
integer :: gpstype
Modified: DART/trunk/obs_sequence/obs_sequence_tool.f90
===================================================================
--- DART/trunk/obs_sequence/obs_sequence_tool.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/obs_sequence/obs_sequence_tool.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -426,11 +426,11 @@
if (first_seq < 0) then
call init_obs_sequence(seq_out, num_copies_out, num_qc_out, size_seq_out)
do j=1, num_copies_out
- meta_data = get_copy_meta_data(seq_in, j)
+ meta_data = get_copy_meta_data(seq_in, j)
call set_copy_meta_data(seq_out, j, meta_data)
enddo
do j=1, num_qc_out
- meta_data = get_qc_meta_data(seq_in, j)
+ meta_data = get_qc_meta_data(seq_in, j)
call set_qc_meta_data(seq_out, j, meta_data)
enddo
first_seq = i
@@ -735,7 +735,7 @@
! validate the metadata string
found = .false.
do i=1, num_qc_in
- meta_data = get_qc_meta_data(seq_in, i)
+ meta_data = get_qc_meta_data(seq_in, i)
if (trim(qc_metadata) == trim(meta_data)) then
call delete_obs_by_qc(i, min_qc, max_qc, seq, all_gone)
found = .true.
@@ -761,7 +761,7 @@
! validate the metadata string
found = .false.
do i=1, num_copies_in
- meta_data = get_copy_meta_data(seq_in, i)
+ meta_data = get_copy_meta_data(seq_in, i)
if (trim(copy_metadata) == trim(meta_data)) then
call delete_obs_by_copy(i, min_copy, max_copy, copy_type, &
seq, all_gone)
@@ -817,8 +817,8 @@
type(obs_type) :: obs, next_obs
type(obs_def_type) :: this_obs_def
logical :: is_there_one, is_this_last
-integer :: size_seq_in, num_copies_in, num_qc_in
-integer :: i, j
+integer :: size_seq_in
+integer :: i
integer :: this_obs_kind
! max_obs_kinds is a public from obs_kind_mod.f90 and really is
! counting the max number of types, not kinds
@@ -944,8 +944,8 @@
type(obs_type) :: obs, next_obs
type(obs_def_type) :: this_obs_def
logical :: is_there_one, is_this_last
-integer :: size_seq, num_copies, num_qc
-integer :: i, j, key
+integer :: size_seq
+integer :: key
type(time_type) :: last_time, this_time
Modified: DART/trunk/smoother/smoother_mod.f90
===================================================================
--- DART/trunk/smoother/smoother_mod.f90 2009-04-15 20:48:36 UTC (rev 3814)
+++ DART/trunk/smoother/smoother_mod.f90 2009-04-16 04:00:44 UTC (rev 3815)
@@ -210,7 +210,7 @@
type(ensemble_type), intent(in) :: ens_handle
-integer :: smoother_tail, j
+integer :: smoother_tail
! must have called init_smoother() before using this routine
if ( .not. module_initialized ) then
More information about the Dart-dev
mailing list