[Dart-dev] [3340] DART/branches/nancy_work: My test branch only;
commit reordered shutdown code for filter
nancy at subversion.ucar.edu
nancy at subversion.ucar.edu
Thu May 15 11:22:03 MDT 2008
An HTML attachment was scrubbed...
URL: http://mailman.ucar.edu/pipermail/dart-dev/attachments/20080515/c03d8de1/attachment.html
-------------- next part --------------
Modified: DART/branches/nancy_work/filter/filter.f90
===================================================================
--- DART/branches/nancy_work/filter/filter.f90 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/filter/filter.f90 2008-05-15 17:22:03 UTC (rev 3340)
@@ -380,12 +380,6 @@
! Compute mean and spread for inflation and state diagnostics
call all_vars_to_all_copies(ens_handle)
- ! TRY RELAXING THE INFLATION HERE; HAVE ALL COPIES SO EASY TO CODE DAMPING
- ens_handle%copies(PRIOR_INF_COPY, :) = 1.0_r8 + &
- inf_damping(1) * (ens_handle%copies(PRIOR_INF_COPY, :) - 1.0_r8)
- ens_handle%copies(POST_INF_COPY, :) = 1.0_r8 + &
- inf_damping(2) * (ens_handle%copies(POST_INF_COPY, :) - 1.0_r8)
-
call compute_copy_mean_sd(ens_handle, 1, ens_size, ENS_MEAN_COPY, ENS_SD_COPY)
if(do_single_ss_inflate(prior_inflate) .or. do_varying_ss_inflate(prior_inflate)) then
@@ -589,21 +583,25 @@
if(ds) call smoother_write_restart(1, ens_size)
call end_ensemble_manager(ens_handle)
-if(my_task_id() == 0) then
- write(logfileunit,*)'FINISHED filter.'
- write(logfileunit,*)
-endif
-
! Free up the observation kind and obs sequence
call destroy_obs(observation)
call destroy_obs_sequence(seq)
if(ds) call smoother_end()
-! Master task must close the log file
+if(my_task_id() == 0) then
+ write(logfileunit,*)'FINISHED filter.'
+ write(logfileunit,*)
+endif
+
+! Master task must close the log file; the magic 'end'
+! flag does that in the timestamp routine.
if(my_task_id() == 0) call timestamp(source,revision,revdate,'end')
-! Make this the last thing done, especially for SGI systems.
+! Make this the very last thing done, especially for SGI systems.
+! It shuts down MPI, and if you try to write after that, they can
+! can discard output that is written after mpi is finalized, or
+! worse, the processes can hang.
call finalize_mpi_utilities(async=async)
end subroutine filter_main
Modified: DART/branches/nancy_work/models/9var/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/9var/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/9var/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -92,9 +92,3 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/MITgcm_annulus/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/MITgcm_annulus/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/MITgcm_annulus/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -92,9 +92,4 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/bgrid_solo/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/bgrid_solo/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/bgrid_solo/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -69,7 +69,6 @@
./preprocess || exit 99
-exit 0
#----------------------------------------------------------------------
# Build all the single-threaded targets
#----------------------------------------------------------------------
@@ -93,12 +92,6 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-
-@ n = $n + 1
-./filter || exit $n
-
#----------------------------------------------------------------------
# to enable an MPI parallel version of filter for this model,
# Turn ON the following block (by fixing the logical expression)
Modified: DART/branches/nancy_work/models/forced_lorenz_96/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/forced_lorenz_96/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/forced_lorenz_96/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -93,20 +93,3 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-
-#----------------------------------------------------------------------
-# For forced L96, we want to allow filter to assimilate forcing.
-# Use vi to change value of reset_forcing in namelist.
-#----------------------------------------------------------------------
-
-echo ':0' >! vi_script
-echo '/reset_forcing' >> vi_script
-echo ':s/true/false/' >> vi_script
-echo ':wq' >> vi_script
-(vi -s vi_script -e input.nml > /dev/null) || exit 98
-
-@ n = $n + 1
-./filter || exit $n
-\rm -f vi_script
Modified: DART/branches/nancy_work/models/ikeda/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/ikeda/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/ikeda/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -67,9 +67,4 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/lorenz_04/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/lorenz_04/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/lorenz_04/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -92,9 +92,3 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/lorenz_63/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/lorenz_63/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/lorenz_63/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -92,9 +92,4 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/lorenz_84/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/lorenz_84/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/lorenz_84/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -92,9 +92,4 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/lorenz_96/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/lorenz_96/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/lorenz_96/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -92,12 +92,6 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-
-@ n = $n + 1
-./filter || exit $n
-
#----------------------------------------------------------------------
# to enable an MPI parallel version of filter for this model,
# uncomment the following block:
Modified: DART/branches/nancy_work/models/lorenz_96_2scale/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/lorenz_96_2scale/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/lorenz_96_2scale/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -91,9 +91,4 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/null_model/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/null_model/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/null_model/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -92,9 +92,4 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/pe2lyr/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/pe2lyr/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/pe2lyr/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -92,9 +92,4 @@
endsw
end
-@ n = $n + 1
-./perfect_model_obs || exit $n
-@ n = $n + 1
-./filter || exit $n
-
Modified: DART/branches/nancy_work/models/simple_advection/work/quickbuild.csh
===================================================================
--- DART/branches/nancy_work/models/simple_advection/work/quickbuild.csh 2008-05-15 17:07:12 UTC (rev 3339)
+++ DART/branches/nancy_work/models/simple_advection/work/quickbuild.csh 2008-05-15 17:22:03 UTC (rev 3340)
@@ -94,8 +94,3 @@
exit
-@ n = $n + 1
-./perfect_model_obs || exit $n
-
-@ n = $n + 1
-./filter || exit $n
More information about the Dart-dev
mailing list