<div dir="ltr"><div class="gmail_default" style="font-size:small">Hi Alan,</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">This looks like a reasonable suggestion, and I agree that the grammar needs to be corrected. I've created a ticket for this, NCL-2203.</div><div class="gmail_default" style="font-size:small"><br></div><div class="gmail_default" style="font-size:small">--Mary</div><div class="gmail_default" style="font-size:small"><br></div></div><div class="gmail_extra"><br><div class="gmail_quote">On Thu, Apr 23, 2015 at 6:06 PM, Alan Brammer <span dir="ltr"><<a href="mailto:abrammer@albany.edu" target="_blank">abrammer@albany.edu</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div class="gmail_default" style="font-family:verdana,sans-serif">Pretty minor request but possibly simple to implement. </div><div class="gmail_default" style="font-family:verdana,sans-serif"><br></div><div class="gmail_default" style="font-family:verdana,sans-serif">When converting an array of floats to integer, missing values trigger the warning </div><div class="gmail_default"><span style="font-family:verdana,sans-serif">"</span><font face="monospace, monospace">there are 1 floats larger than INT_MAX, which has been flagged missing</font><font face="verdana, sans-serif">."</font></div><div class="gmail_default"><font face="verdana, sans-serif">I realise the warning is correct as the default float fillvalue is greater than the max integer, but as it is a fill value and the new array will have a new fill value. I feel this should be dealt with silently, so valid data warnings are not lost. </font></div><div class="gmail_default"><font face="verdana, sans-serif"><br></font></div><div class="gmail_default"><font face="verdana, sans-serif">My view of this would be that fillvalues are converted to the new fillvalue before that line is reached so as to not trigger that warning on missing data. </font></div><div class="gmail_default"><font face="verdana, sans-serif"><br></font></div><div class="gmail_default"><font face="verdana, sans-serif">This may occur on the other type converters, I'm not sure. </font></div><div class="gmail_default"><font face="verdana, sans-serif"><br></font></div><div class="gmail_default"><font face="verdana, sans-serif">Simplistic code to exemplify my concern.</font></div><div class="gmail_default"><font face="verdana, sans-serif"><br></font></div><div class="gmail_default"><font face="monospace, monospace">x = new( 10, float) ; both currently missing</font></div><div class="gmail_default"><font face="monospace, monospace">x(0) = 2.5e10 ; one really big but valid number. </font></div><div class="gmail_default"><font face="monospace, monospace"><br></font></div><div class="gmail_default"><font face="monospace, monospace">; 9 data points are missing, 1 is valid</font></div><div class="gmail_default"><font face="monospace, monospace">xi = toint(x)</font></div><div class="gmail_default"><font face="monospace, monospace">;warning:toint: there are 10 floats larger than INT_MAX, which has been flagged missing.<br></font></div><div class="gmail_default"><span style="font-family:verdana,sans-serif"><br></span></div><div class="gmail_default"><span style="font-family:verdana,sans-serif"><br></span></div><div class="gmail_default"><span style="font-family:verdana,sans-serif"> Really only 1 data point has been flagged missing though, the rest already were missing.</span><br></div><div class="gmail_default"><font face="verdana, sans-serif">If we have a case where we have a large number of data points with some missing it's going to be quite difficult to know when data has actually been lost in the conversion. </font></div><div class="gmail_default"><font face="verdana, sans-serif"><br></font></div><div class="gmail_default"><font face="verdana, sans-serif"><br></font></div><div class="gmail_default"><font face="verdana, sans-serif">Thanks, </font></div><span class="HOEnZb"><font color="#888888"><div class="gmail_default"><font face="verdana, sans-serif">Alan. </font></div></font></span><div class="gmail_default"><br></div><div class="gmail_default">p.s. Having seen a lot of these error message I also noticed the grammar in the error message is questionable. " there are ... which has ... " just to nitpick. </div><div class="gmail_default">Thanks for all your work. </div></div>
<br>_______________________________________________<br>
ncl-talk mailing list<br>
List instructions, subscriber options, unsubscribe:<br>
<a href="http://mailman.ucar.edu/mailman/listinfo/ncl-talk" target="_blank">http://mailman.ucar.edu/mailman/listinfo/ncl-talk</a><br>
<br></blockquote></div><br></div>