<div class="gmail_extra">With these changes, would you like to see all len=* changed to len=StrKIND too? Or just len=#?<br><br>Thanks,<br>Doug<br><br><div class="gmail_quote">On Thu, Apr 26, 2012 at 10:50 AM, Michael Duda <span dir="ltr"><<a href="mailto:duda@ucar.edu" target="_blank">duda@ucar.edu</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi, Doug.<br>
<br>
This sounds like a great idea to me.<br>
<span class="HOEnZb"><font color="#888888"><br>
Michael<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
<br>
On Wed, Apr 25, 2012 at 03:15:05PM -0600, Doug Jacobsen wrote:<br>
> Hi All,<br>
><br>
> I figured I would give everyone one last call for input since I know some<br>
> of you were rather busy last week.<br>
><br>
> I'll work on this tomorrow if I don't hear from anyone. Thanks!<br>
><br>
> Doug<br>
><br>
> On Mon, Apr 16, 2012 at 3:23 PM, Doug Jacobsen<br>
> <<a href="mailto:jacobsen.douglas@gmail.com">jacobsen.douglas@gmail.com</a>>wrote:<br>
><br>
> > Hi Again All,<br>
> ><br>
> > Actually after some discussion within the ocean group here, I think we<br>
> > have come up with a better solution. Though this solution requires more<br>
> > code changes than the simple one I sent out previously.<br>
> ><br>
> > The solution is to define a new kind type, lets call it StrKIND. Then<br>
> > replace the length of all hardcoded strings with this StrKIND. This would<br>
> > allow us to have the length of strings controlled by the mpas_kind_types<br>
> > module.<br>
> ><br>
> > If everyone is ok with this, I can modify it throughout mpas. Just to be<br>
> > clear, all lines that have something like "char (len=32)" would change to<br>
> > "char (len=StrKIND)". This would also change in the gen_inc.c file I<br>
> > attached previously in order to allow the string length to be standard<br>
> > across mpas.<br>
> ><br>
> > If anyone have comments of questions please let me know.<br>
> ><br>
> > I'll probably give this until early next week before I begin working on it.<br>
> ><br>
> > Thanks,<br>
> > Doug<br>
> ><br>
> ><br>
> > On Fri, Apr 13, 2012 at 4:29 PM, Doug Jacobsen <<a href="mailto:jacobsen.douglas@gmail.com">jacobsen.douglas@gmail.com</a><br>
> > > wrote:<br>
> ><br>
> >> Hi All,<br>
> >><br>
> >> We recently came across an issue with registry, where namelist variables<br>
> >> are truncated to be 32 characters in length. This is a problem when we have<br>
> >> really long prefixes for files like the block/proc decomposition files, or<br>
> >> even grid file names. The fix is pretty simple in the<br>
> >> src/registry/gen_inc.c file, but I wanted some input on the max length for<br>
> >> these variables.<br>
> >><br>
> >> Things like the input/output filename are truncated to 1024 within the<br>
> >> MPAS code (see src/framework/mpas_io_input.F) while things like the<br>
> >> decomposition filename are truncated to be 256 characters (see<br>
> >> src/framework/mpas_block_decomp.F).<br>
> >><br>
> >> It seems like overkill to make all strings 1024 (or even 256 for that<br>
> >> matter) but I was curious what everyones preference is. I have attached a<br>
> >> copy of gen_inc.c where I changed the truncation limit from 32 to 256 so<br>
> >> everyone can see what has to change, but feel free to provide input on the<br>
> >> max length for these strings.<br>
> >><br>
> >> Doug<br>
> >><br>
> ><br>
> ><br>
<br>
</div></div><div class="HOEnZb"><div class="h5">> _______________________________________________<br>
> mpas-developers mailing list<br>
> <a href="mailto:mpas-developers@mailman.ucar.edu">mpas-developers@mailman.ucar.edu</a><br>
> <a href="http://mailman.ucar.edu/mailman/listinfo/mpas-developers" target="_blank">http://mailman.ucar.edu/mailman/listinfo/mpas-developers</a><br>
<br>
</div></div></blockquote></div><br></div>