Thanks for the comments Phil,<br><br>I fixed the typo you mentioned, and I have already changed the design document to only provide a public interface to the mpas_get_blocks_per_proc, rather than the lookup table.<br><br>Considering dynamic load balancing, would it be useful to store the local block id, and owning processor number within the block derived data type? I could see at least the local block id being useful, to help you if you need to rearrange the block indices, or insert a new block into the correct position, but I am unsure about the owning proc information. I guess that would just be dminfo % my_proc_id, since you would only have blocks that you would own.<br>
<br>If anyone has any input on these ideas please let me know, but for now I'll add the local block index to the block data type (in the design doc), and leave out the owning proc id.<br><br>Thanks again,<br>Doug<br>
<br>
<div class="gmail_quote">On Fri, Jan 27, 2012 at 3:52 PM, Jones, Philip W <span dir="ltr"><<a href="mailto:pwjones@lanl.gov">pwjones@lanl.gov</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<font face="Calibri, Verdana, Helvetica, Arial"><span style="font-size:12pt"><br>
Doug,<br>
<br>
Generally, I think it’s ok. Couple of minor things below. Michael is correct in saying we want to be careful about holding onto arrays that are proportional to either number of tasks/blocks, even if they appear small now. Memory per node is not growing and
on a per-core basis will continue to shrink. I suspect we will only need these functions on start-up/initialization and may be able to deallocate after this phase is complete (and then the functions would return an error). Once we’ve set up communicators/patterns
for halos, reductions and I/O, I don’t believe we’ll have a need for these sorts of global maps. Even if we did dynamic load balancing, we’d typically be passing off a block or two from one task to another and can update locally without these global queries.
Maybe we can keep these around for now and worry about this later.<br>
<br>
For minor issues:<br>
<br>
Do we want this in the io namelist block? I think there should be a general decomposition group rather than putting this in i/o. (I have other naming preferences too, but that’ll open another can o’ worms).<br>
<br>
The last para on page 6 of the pdf is missing something “wher is the number of proc”. It appears in the tex input too, so it’s not a tex issue.<br>
<br>
Phil<div><div class="h5"><br>
<br>
<br>
On 1/27/12 2:53 PM, "Doug Jacobsen" <<a href="http://jacobsen.douglas@gmail.com" target="_blank">jacobsen.douglas@gmail.com</a>> wrote:<br>
<br>
</div></div></span></font>
<blockquote><font face="Calibri, Verdana, Helvetica, Arial"><span style="font-size:12pt"><div><div class="h5">Hi again all,<br>
<br>
I have now attached the newest version of this design doc.<br>
<br>
Please let me know of any other comments/questions.<br>
<br>
Doug<br>
<br>
</div></div><hr align="CENTER" size="3" width="95%">
</span></font><div class="im"><span style="font-size:12pt"><font face="Courier, Courier New">_______________________________________________<br>
mpas-developers mailing list<br>
<a href="http://mpas-developers@mailman.ucar.edu" target="_blank">mpas-developers@mailman.ucar.edu</a><br>
<a href="http://mailman.ucar.edu/mailman/listinfo/mpas-developers" target="_blank">http://mailman.ucar.edu/mailman/listinfo/mpas-developers</a><br>
</font></span></div></blockquote>
<span style="font-size:12pt"><font face="Courier, Courier New"><br>
<br>
---<br>
Correspondence/TSPA/DUSA EARTH<br>
------------------------------------------------------------<br>
Philip Jones <a href="http://pwjones@lanl.gov" target="_blank">pwjones@lanl.gov</a><br>
Climate, Ocean and Sea Ice Modeling<br>
Los Alamos National Laboratory<br>
T-3 MS B216 Ph: <a href="tel:505-500-2699" value="+15055002699" target="_blank">505-500-2699</a><br>
PO Box 1663 Fax: <a href="tel:505-665-5926" value="+15056655926" target="_blank">505-665-5926</a><br>
Los Alamos, NM 87545-1663<br>
</font></span><font size="1"><font face="Helvetica, Verdana, Arial"><span style="font-size:9pt"><br>
<br>
</span></font></font><font face="Calibri, Verdana, Helvetica, Arial"><span style="font-size:12pt"><br>
</span></font>
</div>
</blockquote></div><br>