<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#ffffff">
Hi Doug,<br>
<br>
Great that you found this bug!<br>
<br>
In other parts of the code, we're using indices of dummy cells to
avoid having to use these kinds of if statements. Is there a way
that approach could be applied to cellsOnEdge in general, and would
it work in the diagnostics?<br>
<br>
-Xylar<br>
<br>
<br>
On 12/20/10 9:19 AM, Doug Jacobsen wrote:
<blockquote
cite="mid:AANLkTin5uYUhX0Xfd0BQnhNevOH4AkVkMTuzrAp8Ukkw@mail.gmail.com"
type="cite">Hi Everyone,
<div><br>
</div>
<div>So, I found a bug in the shallow waters
module_global_diagnostics.F. It's only apparent for limited area
grids. Basically, I was getting cellsOnEdge, and just using both
of them, but on a boundaryEdge one of the two cellsOnEdge is 0,
making it not a valid cell, so the code would segfault. I
changed it to check that both of the two cells were not 0 before
doing the computation, and it appears to work.</div>
<div><br>
</div>
<div>I have attached the file, to see if anyone cared to look at
it. I'll probably commit it tomorrow if I don't hear anything
back. Thanks!</div>
<div><br>
</div>
<div>Doug</div>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
mpas-developers mailing list
<a class="moz-txt-link-abbreviated" href="mailto:mpas-developers@mailman.ucar.edu">mpas-developers@mailman.ucar.edu</a>
<a class="moz-txt-link-freetext" href="http://mailman.ucar.edu/mailman/listinfo/mpas-developers">http://mailman.ucar.edu/mailman/listinfo/mpas-developers</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
***********************
Xylar S. Asay-Davis
E-mail: <a class="moz-txt-link-abbreviated" href="mailto:xylar@lanl.gov">xylar@lanl.gov</a>
Phone: (505) 606-0025
Fax: (505) 665-2659
CNLS, MS B258
Los Alamos National Laboratory
Los Alamos, NM 87545
***********************
</pre>
</body>
</html>