[mpas-developers] COMMIT CHECK: Addition of 4d and 5d reals

Michael Duda duda at ucar.edu
Thu Feb 7 17:47:55 MST 2013


Hi, Doug.

The changes look good to me.

Thanks!
Michael


On Wed, Feb 06, 2013 at 03:12:14PM -0700, Doug Jacobsen wrote:
> Hi again all,
> 
> As this is a bigger commit to the trunk, I wanted to make sure everyone was
> ok with the changes I made before I commit them. So, please let me know if
> anyone has any issues. If not I'll probably commit them on Monday.
> 
> Thanks,
> Doug
> 
> 
> On Thu, Jan 31, 2013 at 8:17 AM, Doug Jacobsen
> <jacobsen.douglas at gmail.com>wrote:
> 
> > Hello All,
> >
> > Recently two projects have been started which require the addition of 4d
> > and 5d real fields. I've added these fields and the associated subroutines
> > that are required to work on them.
> >
> > I haven't added 4d and 5d integers, as each field added adds roughly 1000
> > lines of code across something like 5 new subroutines and additions to 4
> > other subroutines, and I didn't know if anyone would use them.
> > Additionally, I haven't added the ability to have a super array of 5d
> > fields (a 6d real field).
> >
> > I have attached the four files that have been affected by these changes
> > and would appreciate some review of them. I have so far tested that I can
> > add 4 and 5d real fields to registry, and the model runs and writes them to
> > a file.
> >
> > Any comments/questions are appreciated. Thanks!
> > Doug
> >
> >
> >

> _______________________________________________
> mpas-developers mailing list
> mpas-developers at mailman.ucar.edu
> http://mailman.ucar.edu/mailman/listinfo/mpas-developers



More information about the mpas-developers mailing list