[mpas-developers] pv_vertex

[Mark Petersen]

mpas developers,

In all three cores, the pv_vertex section includes the lines

          do i=1,vertexDegree
             if (cellsOnVertex(i,iVertex) > nCells) cycle VTX_LOOP
          end do

so that pv_vertex is zero on boundary vertices.  pv_vertex, like 
vorticity, should generally be nonzero on the boundaries.  I propose to 
delete those lines in the trunk on all three cores.  Note
      kiteAreasOnVertex(i,iVertex)
is zero when referencing land cells, so h_vertex only averages over valid 
cells.

Feedback is welcome.

Mark

************* current version

       ! Compute height at vertices, pv at vertices, and average pv to edge locations
       !  ( this computes pv_vertex at all vertices bounding real cells and distance-1 ghost cells )
       !
       VTX_LOOP: do iVertex = 1,nVertices
          do i=1,grid % vertexDegree
             if (cellsOnVertex(i,iVertex) > nCells) cycle VTX_LOOP
          end do
          do k=1,nVertLevels
             h_vertex(k,iVertex) = 0.0
             do i=1,grid % vertexDegree
                h_vertex(k,iVertex) = h_vertex(k,iVertex) + h(k,cellsOnVertex(i,iVertex)) * kiteAreasOnVertex(i,iVertex)
             end do
             h_vertex(k,iVertex) = h_vertex(k,iVertex) / areaTriangle(iVertex)

             pv_vertex(k,iVertex) = (fVertex(iVertex) + vorticity(k,iVertex)) / h_vertex(k,iVertex)
          end do
       end do VTX_LOOP