[Dart-dev] DART/branches Revision: 12414

dart at ucar.edu dart at ucar.edu
Thu Mar 1 14:53:06 MST 2018


hendric at ucar.edu
2018-03-01 14:53:06 -0700 (Thu, 01 Mar 2018)
212
setting missing status values for observation vertical
conversion.  adding obs_def_upper_atm.f90 to the namelist,
and setting bad vertical conversion status to 8 to
avoid confusion with failed forward operator.




Modified: DART/branches/recam/assimilation_code/modules/assimilation/quality_control_mod.f90
===================================================================
--- DART/branches/recam/assimilation_code/modules/assimilation/quality_control_mod.f90	2018-03-01 20:38:32 UTC (rev 12413)
+++ DART/branches/recam/assimilation_code/modules/assimilation/quality_control_mod.f90	2018-03-01 21:53:06 UTC (rev 12414)
@@ -57,7 +57,7 @@
 integer, parameter :: DARTQC_NOT_IN_NAMELIST       = 5
 integer, parameter :: DARTQC_BAD_INCOMING_QC       = 6
 integer, parameter :: DARTQC_FAILED_OUTLIER_TEST   = 7
-integer, parameter :: DARTQC_FAILED_VERT_CONVERT   = 4   ! change this to 8 after we test more
+integer, parameter :: DARTQC_FAILED_VERT_CONVERT   = 8   ! change this to 8 after we test more
 !integer, parameter :: DARTQC_FAILED_VERT_CONVERT   = 8
 !integer, parameter :: DARTQC_OUTSIDE_DOMAIN        = 9  ! we have no way (yet) for the model_mod to signal this
 

Modified: DART/branches/recam/models/cam-fv/model_mod.f90
===================================================================
--- DART/branches/recam/models/cam-fv/model_mod.f90	2018-03-01 20:38:32 UTC (rev 12413)
+++ DART/branches/recam/models/cam-fv/model_mod.f90	2018-03-01 21:53:06 UTC (rev 12414)
@@ -3400,6 +3400,8 @@
 
 call set_vertical(location, pressure_array(1), VERTISPRESSURE)
 
+my_status = 0
+
 end subroutine obs_vertical_to_pressure
 
 !--------------------------------------------------------------------
@@ -3429,6 +3431,8 @@
 
 call set_vertical(location, height_array(1), VERTISHEIGHT)
 
+my_status = 0
+
 end subroutine obs_vertical_to_height
 
 !--------------------------------------------------------------------
@@ -3453,6 +3457,8 @@
 
 call set_vertical(location, level_array(1), VERTISLEVEL)
 
+my_status = 0
+
 end subroutine obs_vertical_to_level
 
 !--------------------------------------------------------------------
@@ -3473,6 +3479,7 @@
 ! by definition
 if (query_location(location) == VERTISSURFACE) then
    call set_vertical(location, -log(1.0_r8), VERTISSCALEHEIGHT)
+   my_status = 2
    return
 endif
    
@@ -3501,6 +3508,8 @@
 
 call set_vertical(location, scaleheight_val, VERTISSCALEHEIGHT)
 
+my_status = 0
+
 end subroutine obs_vertical_to_scaleheight
 
 !--------------------------------------------------------------------
@@ -3962,8 +3971,6 @@
 
 endif
 
-print*, 'p_surface, p_above', p_surface, p_above, diff
-
 end function scale_height
 
 !--------------------------------------------------------------------

Modified: DART/branches/recam/models/cam-fv/work/input.nml
===================================================================
--- DART/branches/recam/models/cam-fv/work/input.nml	2018-03-01 20:38:32 UTC (rev 12413)
+++ DART/branches/recam/models/cam-fv/work/input.nml	2018-03-01 21:53:06 UTC (rev 12414)
@@ -364,6 +364,7 @@
   input_files              = '../../../observations/forward_operators/obs_def_gps_mod.f90',
                              '../../../observations/forward_operators/obs_def_reanalysis_bufr_mod.f90',
                              '../../../observations/forward_operators/obs_def_altimeter_mod.f90',
+                             '../../../observations/forward_operators/obs_def_upper_atm_mod.f90',
    /
 
 ! Not usually assimilated.  No fundamental reason not to. 


More information about the Dart-dev mailing list