[Dart-dev] DART/branches Revision: 12805

[dart at ucar.edu]

thoar at ucar.edu
2018-08-31 10:53:03 -0600 (Fri, 31 Aug 2018)
144
Cleanup complete. Replaced old glade paths with new glade paths.
Added comments to cice obs converters to explain how we think they were used.




Modified: DART/branches/yz-cice/assimilation_code/modules/observations/DEFAULT_obs_kind_mod.F90
===================================================================
--- DART/branches/yz-cice/assimilation_code/modules/observations/DEFAULT_obs_kind_mod.F90	2018-08-31 16:35:42 UTC (rev 12804)
+++ DART/branches/yz-cice/assimilation_code/modules/observations/DEFAULT_obs_kind_mod.F90	2018-08-31 16:53:03 UTC (rev 12805)
@@ -22,10 +22,18 @@
 implicit none
 private
 
-public :: get_name_for_type_of_obs, assimilate_this_type_of_obs, &
-          evaluate_this_type_of_obs, get_quantity_for_type_of_obs, get_index_for_type_of_obs, &
-          write_type_of_obs_table, read_type_of_obs_table, get_type_of_obs_from_menu, map_type_of_obs_table,  &
-          use_ext_prior_this_type_of_obs, get_name_for_quantity, get_index_for_quantity
+public :: get_name_for_type_of_obs,       &
+          assimilate_this_type_of_obs,    &
+          evaluate_this_type_of_obs,      &
+          get_quantity_for_type_of_obs,   &
+          get_index_for_type_of_obs,      &
+          write_type_of_obs_table,        &
+          read_type_of_obs_table,         &
+          get_type_of_obs_from_menu,      &
+          map_type_of_obs_table,          &
+          use_ext_prior_this_type_of_obs, &
+          get_name_for_quantity,          &
+          get_index_for_quantity
 
 ! Added by nsc to try to limit the number of global vars exported from
 ! this program.  i do not like this terminology, but since we are still
@@ -475,10 +483,10 @@
 !----------------------------------------------------------------------------
 
 ! version controlled file description for error handling, do not edit
-character(len=256), parameter :: source   = &
+character(len=*), parameter :: source   = &
    "$URL$"
-character(len=32 ), parameter :: revision = "$Revision$"
-character(len=128), parameter :: revdate  = "$Date$"
+character(len=*), parameter :: revision = "$Revision$"
+character(len=*), parameter :: revdate  = "$Date$"
 
 logical, save :: module_initialized = .false.
 

Modified: DART/branches/yz-cice/build_templates/mkmf.template
===================================================================
--- DART/branches/yz-cice/build_templates/mkmf.template	2018-08-31 16:35:42 UTC (rev 12804)
+++ DART/branches/yz-cice/build_templates/mkmf.template	2018-08-31 16:53:03 UTC (rev 12805)
@@ -1,4 +1,4 @@
-# Template for Intel Fortran Compiler on Linux clusters and workstations.
+# Template for GNU gfortran on Linux or Mac OSX
 #
 # DART software - Copyright UCAR. This open source software is provided
 # by UCAR, "as is", without charge, subject to all terms of use at
@@ -9,107 +9,57 @@
 # typical use with mkmf
 # mkmf -t mkmf.template.xxxx ...
 #
-# FFLAGS   useful for DEBUGGING. NOTE: The intel compiler can provide a lot more
-#          information if you LEAVE the object and module files intact.
-#          Do not remove the *.o and *.mod files when debugging code.
+# Suggested (perhaps required) flags:
+# -ffree-line-length-none   handles "long" lines - i.e. longer than 72 chars
 #
-#     -g       include debugging information.  these are all synonyms.
-#     -debug full
-#     -debug all
-#     -O0      setting -g will make this the default (no optimization).
-#              it is possible to set -g and then explicitly set -O2 if
-#              the behavior being debugged depends on optimization changes.
-#     -ftrapuv   traps if a local variable is used before being set
-#     -C       enables all runtime checks.  -C and -check all are synonyms.
-#     -check all
-#     -check <keywords>    enables/disables more specific runtime checks.
-#           keywords:  [arg_temp_created,bounds,overflow,format,pointers,uninit]
-#     -warn <keywords>  the level of warning messages issued.
-#           keywords:  [alignments, argument_checking, declarations,
-#                      errors, fileopt, general, ignore_loc,
-#                      stderrors, truncated_source, uncalled,
-#                      uninitialized, unused, usage, all]
-#     -fp-stack-check  catches conditions where the FP stack is not correct.
-#           Typically this is when a real function is called as if it were a
-#           subroutine, OR a subroutine is called as if it were a function (return
-#           values left of FP stack OR too much data is taken off the FP stack)
-#     -vec-reportN  controls how much diagnostic output is printed about
-#                   loops vectorized by the compiler. N = 0 is silent,
-#                   N can have values up to 5.
-#     -traceback    tells the compiler to generate extra information in the
-#                   object file to provide source file traceback information
-#                   when a severe error occurs at run time
+# Suggested debugging flags:
+#  -g                  add debugging information to executable
+#  -Wuninitialized     catch uninitialized variables
+#  -Wunused            issue warning for unused variables - keeps code clean
+#  -fbacktrace         runtime errors try to print out a stack backtrace
+#  -fbounds-check      add runtime-checking for out-of-range array indices
+#  -ffpe-trap=invalid,zero,overflow
+#                      stop on floating point errors
 #
-# FFLAGS   useful for bitwise reproducibility and accuracy control
-#          (these will slow down performance to various degrees)
-#     -fp-model precise    control how floating point roundoff is done so it is
-#                          reproducible from run to run.  in simple tests this