[Dart-dev] DART/branches Revision: 11616

dart at ucar.edu dart at ucar.edu
Tue May 9 17:30:06 MDT 2017


thoar at ucar.edu
2017-05-09 17:30:06 -0600 (Tue, 09 May 2017)
168
Since the name of the 'true state' is known (true_state.nc) we
can remove the prompting for this filename or the need to supply
it as an argument.  Simplifies things.




Modified: DART/branches/rma_trunk/diagnostics/matlab/plot_bins.m
===================================================================
--- DART/branches/rma_trunk/diagnostics/matlab/plot_bins.m	2017-05-09 19:52:25 UTC (rev 11615)
+++ DART/branches/rma_trunk/diagnostics/matlab/plot_bins.m	2017-05-09 23:30:06 UTC (rev 11616)
@@ -1,4 +1,4 @@
-function plot_bins(truth_file, diagn_file)
+function plot_bins(diagn_file)
 %% DART:plot_bins Plots ensemble rank histograms
 %
 % plot_bins    interactively queries for the information needed to create
@@ -6,12 +6,11 @@
 %              need different pieces of information ... the model types are
 %              determined and additional user input may be queried.
 %
-% Ultimately, plot_bins will be replaced by a GUI.
-% In the end, the heavy lifting is done by PlotBins.
+% The true state ('true_state.nc') is REQUIRED.
 %
 % A reminder of the sequence:
 % truth  run (from    pmo):
-%           perfect_input  --->  true_state.nc
+%           perfect_input  --->  true_state.nc   REQUIRED
 % filter run (from filter):
 %           filter_input.nc  --->  [prior inflation]  --->
 %                 preassim.nc   --->  [assimilation]  --->
@@ -18,13 +17,12 @@
 %                       postassim.nc  ---> [posterior inflation]  --->
 %                             filter_output.nc
 %
-% Example 1  (Prompt for filenames. Defaults are 'true_state.nc' and 'preassim.nc')
+% Example 1  (Prompt for filter output filename. Default is 'preassim.nc')
 % plot_bins
 %
 % Example 2
-% truth_file = 'true_state.nc';
 % diagn_file = 'preassim.nc';
-% plot_bins(truth_file,diagn_file)
+% plot_bins(diagn_file)
 
 %% DART software - Copyright UCAR. This open source software is provided
 % by UCAR, "as is", without charge, subject to all terms of use at
@@ -37,22 +35,19 @@
 %                     the value of the variable is checked later.
 
 if (nargin == 0)
-    disp('Input name of true model trajectory file:')
-    truth_file = input('<cr> for true_state.nc\n','s');
-    if isempty(truth_file)
-        truth_file = 'true_state.nc';
-    end
     disp('Input name of ensemble trajectory file:')
     diagn_file = input('<cr> for preassim.nc\n','s');
     if isempty(diagn_file)
         diagn_file = 'preassim.nc';
     end
-elseif (nargin == 2)
+elseif (nargin == 1)
     % all good - nothing to do
 else
-    error('Must supply either two filenames or none.')
+    error('Must supply exactly one filename or none.')
 end
 
+truth_file = 'true_state.nc';
+
 if ( exist(truth_file,'file') ~= 2 ), error('%s does not exist.',truth_file); end
 if ( exist(diagn_file,'file') ~= 2 ), error('%s does not exist.',diagn_file); end
 

Modified: DART/branches/rma_trunk/diagnostics/matlab/plot_ens_err_spread.m
===================================================================
--- DART/branches/rma_trunk/diagnostics/matlab/plot_ens_err_spread.m	2017-05-09 19:52:25 UTC (rev 11615)
+++ DART/branches/rma_trunk/diagnostics/matlab/plot_ens_err_spread.m	2017-05-09 23:30:06 UTC (rev 11616)
@@ -1,4 +1,4 @@
-function plot_ens_err_spread(truth_file, diagn_file)
+function plot_ens_err_spread(diagn_file)
 %% DART: plot_ens_err_spread - summary plots of the ensemble error and ensemble spread.
 %                        Interactively queries for the needed information.
 %                        Since different models potentially need different
@@ -5,12 +5,13 @@
 %                        pieces of information ... the model types are
 %                        determined and additional user input may be queried.
 %
-% Ultimately, plot_ens_err_spread will be replaced by a GUI.
-% All the heavy lifting is done by PlotEnsErrSpread.
+% 
 %
+% The true state ('true_state.nc') is REQUIRED.
+%
 % A reminder of the sequence:
 % truth  run (from    pmo):
-%           perfect_input  --->  true_state.nc
+%           perfect_input  --->  true_state.nc   REQUIRED
 % filter run (from filter):
 %           filter_input.nc  --->  [prior inflation]  --->
 %                 preassim.nc   --->  [assimilation]  --->
@@ -17,13 +18,12 @@
 %                       postassim.nc  ---> [posterior inflation]  --->
 %                             filter_output.nc
 %
-% Example 1  (Prompt for filenames. Defaults are 'true_state.nc' and 'preassim.nc')


More information about the Dart-dev mailing list