[Dart-dev] DART/branches Revision: 12171

[dart at ucar.edu]

thoar at ucar.edu
2017-12-04 10:26:20 -0700 (Mon, 04 Dec 2017)
374
The web page is now relevant for ROMS.
The scripts need to be vetted for LSF.
Since PBS and SLURM are so similar, it is not clear if both
systems need to be supported. On at least one architecture, 
the SLURM block was ignored because it came after the PBS block
and SLURM actually USED the PBS directives (before it found the
SLURM directives). More testing is necessary.




Modified: DART/branches/rma_trunk/models/ROMS/model_mod.f90
===================================================================
--- DART/branches/rma_trunk/models/ROMS/model_mod.f90	2017-12-02 22:05:02 UTC (rev 12170)
+++ DART/branches/rma_trunk/models/ROMS/model_mod.f90	2017-12-04 17:26:20 UTC (rev 12171)
@@ -140,6 +140,7 @@
 logical, save :: module_initialized = .false.
 
 ! things which can/should be in the model_nml
+!>@todo FIXME ... replace remaining references to VERTISHEIGHT with vert_localization_coord
 logical  :: output_state_vector          = .false.
 integer  :: assimilation_period_days     = 1
 integer  :: assimilation_period_seconds  = 0
@@ -300,19 +301,19 @@
 !> @param istatus interpolation status ... 0 == success, /=0 is a failure
 !>
 
-subroutine model_interpolate(state_handle, ens_size, location, obs_type, interp_val, istatus)
+subroutine model_interpolate(state_handle, ens_size, location, obs_type, expected_obs, istatus)
 
- type(ensemble_type), intent(in) :: state_handle
- integer,             intent(in) :: ens_size
- type(location_type), intent(in) :: location
- integer,             intent(in) :: obs_type
- integer,            intent(out) :: istatus(ens_size)
- real(r8),           intent(out) :: interp_val(ens_size) !< array of interpolated values
+type(ensemble_type), intent(in)  :: state_handle
+integer,             intent(in)  :: ens_size
+type(location_type), intent(in)  :: location
+integer,             intent(in)  :: obs_type
+real(r8),            intent(out) :: expected_obs(:)
+integer,             intent(out) :: istatus(:)
 
 if ( .not. module_initialized ) call static_init_model
 
 ! Successful istatus is 0
-interp_val = MISSING_R8
+expected_obs = MISSING_R8
 istatus = 99
 
 write(string1,*)'model_interpolate should not be called.'
@@ -1009,7 +1010,7 @@
    ! Make sure DART kind is valid
 
    if( get_index_for_quantity(dartstr) < 0 ) then
-      write(string1,'(''there is no obs_kind <'',a,''> in obs_kind_mod.f90'')') trim(dartstr)
+      write(string1,'(''there is no quantity <'',a,''> in obs_kind_mod.f90'')') trim(dartstr)
       call error_handler(E_ERR,'parse_variable_input:',string1,source,revision,revdate)
    endif
 

Modified: DART/branches/rma_trunk/models/ROMS/model_mod.html
===================================================================
--- DART/branches/rma_trunk/models/ROMS/model_mod.html	2017-12-02 22:05:02 UTC (rev 12170)
+++ DART/branches/rma_trunk/models/ROMS/model_mod.html	2017-12-04 17:26:20 UTC (rev 12171)
@@ -31,82 +31,226 @@
 <A HREF="#References">REFERENCES</A> /
 <A HREF="#Errors">ERRORS</A> /
 <A HREF="#FuturePlans">PLANS</A> /
-<A HREF="#PrivateComponents">PRIVATE COMPONENTS</A> /
 <A HREF="#Legalese">TERMS OF USE</A>
 
 <H2>Overview</H2>
 
 <P>
-DART interface module for the ROMS model.  This page documents the details of
-the module compiled into DART that interfaces with the ROMS data in
-the state vector.
+This is the DART interface to the 
+<a href="https://www.myroms.org">Regional Ocean Modeling System</a> - <strong>ROMS</strong>.
+This document describes the relationship between ROMS and DART and provides an overview of
+how to perform ensemble data assimilation with ROMS to provide ocean states that are 
+consistent with the information provided by various ocean observations.
+<br />
+<br />
+Running ROMS is complicated. It is <strong>strongly</strong> recommended that you become 
+very familiar with running ROMS before you attempt a ROMS-DART assimilation experiment.
+Running DART is complicated. It is <strong>strongly</strong> recommended that you become
+very familiar with running DART before you attempt a ROMS-DART assimilation experiment.
+Running ROMS-DART takes expertise in both areas.
+<br />
+<br />
+We recommend working through the 
+<a href="../../documentation/tutorial/index.html">DART tutorial</a> to learn the concepts
+of ensemble data assimilation and the capabilities of DART.
+<br />
+<br />
+The ROMS code is not distributed with DART, it can be obtained from the ROMS website 
+<a href="https://www.myroms.org">https://www.myroms.org</a>. There you will also find 
+instructions on how to compile and run ROMS. DART can use the 'verification observations'
+from ROMS (basically the estimate of the observation at the location and time 
+computed as the model advances) so it would be worthwhile to become familiar with 
+that capability of ROMS. DART calls these 'precomputed forward operators'.  
+<br />
+<br />
+DART can also use observations from the
+<a href="https://www.nodc.noaa.gov/OC5/indprod.html">World Ocean Database</a> - WOD. 
+The conversion from the WOD formats to the DART observation sequence format is 
+accomplished by the converters in the
+<em class=file>observations/obs_converters/WOD</em> directory. They are described
+by <a href="../../observations/obs_converters/WOD/WOD.html">WOD.html</a>.
+The DART forward operators require interpolation from the ROMS