[Dart-dev] DART/branches Revision: 11525

[dart at ucar.edu]

thoar at ucar.edu
2017-04-26 16:20:15 -0600 (Wed, 26 Apr 2017)
110
cleaned up comments pertaining to nc_write_model_atts
now that they do not instantiate prognostic variables.




Modified: DART/branches/rma_output_files/models/forced_lorenz_96/model_mod.f90
===================================================================
--- DART/branches/rma_output_files/models/forced_lorenz_96/model_mod.f90	2017-04-26 22:13:01 UTC (rev 11524)
+++ DART/branches/rma_output_files/models/forced_lorenz_96/model_mod.f90	2017-04-26 22:20:15 UTC (rev 11525)
@@ -604,28 +604,7 @@
 
 function nc_write_model_vars( ncFileID, statevec, copyindex, timeindex ) result (ierr)         
 !------------------------------------------------------------------
-! Writes the model-specific attributes to a netCDF file
-! TJH 23 May 2003
-!
-! TJH 29 July 2003 -- for the moment, all errors are fatal, so the
-! return code is always '0 == normal', since the fatal errors stop execution.
-!
-! For the lorenz_96 model, each state variable is at a separate location.
-! that's all the model-specific attributes I can think of ...
-!
-! assim_model_mod:init_diag_output uses information from the location_mod
-!     to define the location dimension and variable ID. All we need to do
-!     is query, verify, and fill ...
-!
-! Typical sequence for adding new dimensions,variables,attributes:
-! NF90_OPEN             ! open existing netCDF dataset
-!    NF90_redef         ! put into define mode
-!    NF90_def_dim       ! define additional dimensions (if any)
-!    NF90_def_var       ! define variables: from name, type, and dims
-!    NF90_put_att       ! assign attribute values
-! NF90_ENDDEF           ! end definitions: leave define mode
-!    NF90_put_var       ! provide values for variable
-! NF90_CLOSE            ! close: save updated netCDF dataset
+! Writes the model-specific variables to a netCDF file
 
 use typeSizes
 use netcdf

Modified: DART/branches/rma_output_files/models/lorenz_63/model_mod.f90
===================================================================
--- DART/branches/rma_output_files/models/lorenz_63/model_mod.f90	2017-04-26 22:13:01 UTC (rev 11524)
+++ DART/branches/rma_output_files/models/lorenz_63/model_mod.f90	2017-04-26 22:20:15 UTC (rev 11525)
@@ -446,7 +446,6 @@
 
 model_mod_writes_state_variables = .false.
 
-
 ! make sure ncFileID refers to an open netCDF file 
 
 ! are the inq and sync needed?  can we just redef here?
@@ -509,8 +508,6 @@
    call nc_check(nf90_put_var(ncFileID, LocationVarID, get_location(lctn), (/ i /) ), &
                  'nc_write_model_atts', 'nf90_put_var LocationVarID 2')
 enddo
-!--------------------------------------------------------------------
-!--------------------------------------------------------------------
 
 call nc_check(nf90_sync(ncFileID), 'nc_write_model_atts', 'nf90_sync')
 

Modified: DART/branches/rma_output_files/models/lorenz_96/model_mod.f90
===================================================================
--- DART/branches/rma_output_files/models/lorenz_96/model_mod.f90	2017-04-26 22:13:01 UTC (rev 11524)
+++ DART/branches/rma_output_files/models/lorenz_96/model_mod.f90	2017-04-26 22:20:15 UTC (rev 11525)
@@ -403,41 +403,7 @@
 end subroutine get_close_obs
 
 !------------------------------------------------------------------
-
-!> @todo can we replace most of this with:
-!> 
-!> call put_standard_attributes()
-!> call put_my_model_name("Lorenz_96")
-!> call put_model_info("model_forcing", forcing)
-!> call put_model_info("model_delta_t", delta_t)
-
-
-! Can't write netcdf i8 - do we just have 
-! a 32 bit version of the netcdf library?
-! Bgrid errors out if we have an model size greater than largest i4
-
 ! Writes the model-specific attributes to a netCDF file
-! TJH Jan 24 2003
-!
-! TJH 29 July 2003 -- for the moment, all errors are fatal, so the
-! return code is always '0 == normal', since the fatal errors stop execution.
-!
-! For the lorenz_96 model, each state variable is at a separate location.
-! that's all the model-specific attributes I can think of ...
-!
-! assim_model_mod:init_diag_output uses information from the location_mod
-!     to define the location dimension and variable ID. All we need to do
-!     is query, verify, and fill ...
-!
-! Typical sequence for adding new dimensions,variables,attributes:
-! NF90_OPEN             ! open existing netCDF dataset
-!    NF90_redef         ! put into define mode 
-!    NF90_def_dim       ! define additional dimensions (if any)
-!    NF90_def_var       ! define variables: from name, type, and dims
-!    NF90_put_att       ! assign attribute values
-! NF90_ENDDEF           ! end definitions: leave define mode
-!    NF90_put_var       ! provide values for variable
-! NF90_CLOSE            ! close: save updated netCDF dataset