[Dart-dev] DART/branches Revision: 10754

[dart at ucar.edu]

thoar at ucar.edu
2016-11-15 13:18:51 -0700 (Tue, 15 Nov 2016)
503
Removed the references to pop_to_dart and dart_to_pop.
Change the input.nml so that it can run the rma_trunk.
Change the assimilate.csh script to simply modify the POP
restart files IN-PLACE. Since there is no file conversion
going on, there is no need for separate directories for each
ensemble member, nor is there a need for an assimilate directory.
Everything just happens in the CESM RUN dir.

The documentation matches the rma implementation, and has the subroutine
comments in 'doxygen' style.
 



Modified: DART/branches/rma_trunk/models/POP/README
===================================================================
--- DART/branches/rma_trunk/models/POP/README	2016-11-15 18:05:19 UTC (rev 10753)
+++ DART/branches/rma_trunk/models/POP/README	2016-11-15 20:18:51 UTC (rev 10754)
@@ -1,9 +1,17 @@
-# DART software - Copyright 2004 - 2011 UCAR. This open source software is
+# DART software - Copyright 2004 - 2016 UCAR. This open source software is
 # provided by UCAR, "as is", without charge, subject to all terms of use at
 # http://www.image.ucar.edu/DAReS/DART/DART_download
 #
 # DART $Id$
 
+10 Nov 2016 -  TJH
+
+I no longer have access to the LANL version of POP and cannot test these
+interfaces. The scripts to advance LANL/POP will surely change. There is
+one area that may be impacted by reading/writing netCDF directly. Since
+we no longer have a 'dart_to_pop' executable, the communication of the
+'advance_to_time' to the updated POP &time_manager_nml is untested.
+
 30 June 2010 - TJH
 
 The POP interface to DART is available for general use. There are two

Modified: DART/branches/rma_trunk/models/POP/dart_pop_mod.f90
===================================================================
--- DART/branches/rma_trunk/models/POP/dart_pop_mod.f90	2016-11-15 18:05:19 UTC (rev 10753)
+++ DART/branches/rma_trunk/models/POP/dart_pop_mod.f90	2016-11-15 20:18:51 UTC (rev 10754)
@@ -13,7 +13,7 @@
 use    utilities_mod, only : get_unit, open_file, close_file, file_exist, &
                              register_module, error_handler, nc_check, &
                              find_namelist_in_file, check_namelist_read, &
-                             E_ERR, E_MSG, find_textfile_dims, &
+                             E_ERR, E_WARN, E_MSG, find_textfile_dims, &
                              logfileunit
 
 use typesizes
@@ -261,15 +261,14 @@
 
 
 !------------------------------------------------------------------
+!> Read the lon, lat grid size from the restart netcdf file.
+!> The actual grid file is a binary file with no header information.
+!>
+!> The file name comes from module storage ... namelist.
 
 
 subroutine get_horiz_grid_dims(Nx, Ny)
 
-! Read the lon, lat grid size from the restart netcdf file.
-! The actual grid file is a binary file with no header information.
-!
-! The file name comes from module storage ... namelist.
-
 integer, intent(out) :: Nx   ! Number of Longitudes
 integer, intent(out) :: Ny   ! Number of Latitudes
 
@@ -319,13 +318,12 @@
 
 
 !------------------------------------------------------------------
+!> count the number of lines in the ascii file to figure out max
+!> number of vert blocks.
 
 
 subroutine get_vert_grid_dim(Nz)
 
-! count the number of lines in the ascii file to figure out max
-! number of vert blocks.
-
 integer, intent(out) :: Nz
 
 integer :: linelen ! disposable
@@ -338,15 +336,15 @@
 
 
 !------------------------------------------------------------------
+!> the initialize_module ensures that the pop namelists are read and
+!> the DART time manager gets the pop calendar setting.
+!>
+!> Then, the DART time manager is queried to return what it knows ...
 
 
 subroutine get_pop_calendar(calstring)
 
-! the initialize_module ensures that the pop namelists are read and
-! the DART time manager gets the pop calendar setting.
-!
-! Then, the DART time manager is queried to return what it knows ...
-!
+
 character(len=*), INTENT(OUT) :: calstring
 
 if ( .not. module_initialized ) call initialize_module
@@ -357,14 +355,13 @@
 
 
 !------------------------------------------------------------------
+!> the initialize_module ensures that the pop namelists are read.
+!> The restart times in the pop_in&restart_nml are used to define
+!> appropriate assimilation timesteps.