[Dart-dev] [10332] DART:

nancy at ucar.edu nancy at ucar.edu
Thu Jun 2 10:40:16 MDT 2016


Revision: 10332
Author:   thoar
Date:     2016-06-02 10:40:15 -0600 (Thu, 02 Jun 2016)
Log Message:
-----------

These few instances wrote the namelist to the log file instead of the namelist
file  - i.e. they incorrectly implemented the do_nml_file() call.
I searched ALL the .f90 files in both the trunk and the rma_trunk for this situation.

Modified Paths:
--------------
    DART/branches/rma_trunk/models/bgrid_solo/model_mod.f90
    DART/branches/rma_trunk/observations/NCEP/ascii_to_obs/create_real_obs.f90
    DART/branches/rma_trunk/observations/NCEP/ascii_to_obs/prepbufr_to_obs.f90
    DART/trunk/models/bgrid_solo/model_mod.f90
    DART/trunk/observations/NCEP/ascii_to_obs/create_real_obs.f90
    DART/trunk/observations/NCEP/ascii_to_obs/prepbufr_to_obs.f90

-------------- next part --------------
Modified: DART/branches/rma_trunk/models/bgrid_solo/model_mod.f90
===================================================================
--- DART/branches/rma_trunk/models/bgrid_solo/model_mod.f90	2016-05-31 22:15:22 UTC (rev 10331)
+++ DART/branches/rma_trunk/models/bgrid_solo/model_mod.f90	2016-06-02 16:40:15 UTC (rev 10332)
@@ -557,8 +557,8 @@
 !----- write version and namelist to log file -----
 
    call write_version_number ( version, tag )
-   if (do_nml_file()) write (stdlog(),    nml=atmosphere_nml)
-   if (do_nml_term()) write (nmlfileunit, nml=atmosphere_nml)
+   if (do_nml_file()) write (nmlfileunit, nml=atmosphere_nml)
+   if (do_nml_term()) write (stdlog(),    nml=atmosphere_nml)
 
 !---- compute physics/atmos time step in seconds ----
 

Modified: DART/branches/rma_trunk/observations/NCEP/ascii_to_obs/create_real_obs.f90
===================================================================
--- DART/branches/rma_trunk/observations/NCEP/ascii_to_obs/create_real_obs.f90	2016-05-31 22:15:22 UTC (rev 10331)
+++ DART/branches/rma_trunk/observations/NCEP/ascii_to_obs/create_real_obs.f90	2016-06-02 16:40:15 UTC (rev 10332)
@@ -11,7 +11,7 @@
                              static_init_obs_sequence, destroy_obs_sequence 
 use     real_obs_mod, only : real_obs_sequence
 use    utilities_mod, only : initialize_utilities, register_module,            &
-                             do_output, logfileunit, do_nml_file, do_nml_term, &
+                             do_output, nmlfileunit, do_nml_file, do_nml_term, &
                              error_handler, finalize_utilities, E_ERR, E_MSG,  &
                              find_namelist_in_file, check_namelist_read
 
@@ -96,7 +96,7 @@
 call check_namelist_read(iunit, io, "ncepobs_nml")
 
 ! Record the namelist values used for the run ...
-if (do_nml_file()) write(logfileunit, nml=ncepobs_nml)
+if (do_nml_file()) write(nmlfileunit, nml=ncepobs_nml)
 if (do_nml_term()) write(     *     , nml=ncepobs_nml)
 
 ! Loop through the days interested.

Modified: DART/branches/rma_trunk/observations/NCEP/ascii_to_obs/prepbufr_to_obs.f90
===================================================================
--- DART/branches/rma_trunk/observations/NCEP/ascii_to_obs/prepbufr_to_obs.f90	2016-05-31 22:15:22 UTC (rev 10331)
+++ DART/branches/rma_trunk/observations/NCEP/ascii_to_obs/prepbufr_to_obs.f90	2016-06-02 16:40:15 UTC (rev 10332)
@@ -11,7 +11,7 @@
                               register_module, error_handler, &
                               timestamp, is_longitude_between, &
                               initialize_utilities, register_module,            &
-                              do_output, logfileunit, do_nml_file, do_nml_term, &
+                              do_output, nmlfileunit, do_nml_file, do_nml_term, &
                               finalize_utilities, E_ERR, E_MSG,  &
                               find_namelist_in_file, check_namelist_read
 use  obs_def_mod,      only : obs_def_type, get_obs_def_time, read_obs_def, &
@@ -143,7 +143,7 @@
 call check_namelist_read(iunit, io, "prepbufr_to_obs_nml")
 
 ! Record the namelist values used for the run
-if (do_nml_file()) write(logfileunit, nml=prepbufr_to_obs_nml)
+if (do_nml_file()) write(nmlfileunit, nml=prepbufr_to_obs_nml)
 if (do_nml_term()) write(     *     , nml=prepbufr_to_obs_nml)
 
 ! set observation calendar type and start/end dates

Modified: DART/trunk/models/bgrid_solo/model_mod.f90
===================================================================
--- DART/trunk/models/bgrid_solo/model_mod.f90	2016-05-31 22:15:22 UTC (rev 10331)
+++ DART/trunk/models/bgrid_solo/model_mod.f90	2016-06-02 16:40:15 UTC (rev 10332)
@@ -538,8 +538,8 @@
 !----- write version and namelist to log file -----
 
    call write_version_number ( version, tag )
-   if (do_nml_file()) write (stdlog(),    nml=atmosphere_nml)
-   if (do_nml_term()) write (nmlfileunit, nml=atmosphere_nml)
+   if (do_nml_file()) write (nmlfileunit, nml=atmosphere_nml)
+   if (do_nml_term()) write (stdlog(),    nml=atmosphere_nml)
 
 !---- compute physics/atmos time step in seconds ----
 

Modified: DART/trunk/observations/NCEP/ascii_to_obs/create_real_obs.f90
===================================================================
--- DART/trunk/observations/NCEP/ascii_to_obs/create_real_obs.f90	2016-05-31 22:15:22 UTC (rev 10331)
+++ DART/trunk/observations/NCEP/ascii_to_obs/create_real_obs.f90	2016-06-02 16:40:15 UTC (rev 10332)
@@ -11,7 +11,7 @@
                              static_init_obs_sequence, destroy_obs_sequence 
 use     real_obs_mod, only : real_obs_sequence
 use    utilities_mod, only : initialize_utilities, register_module,            &
-                             do_output, logfileunit, do_nml_file, do_nml_term, &
+                             do_output, nmlfileunit, do_nml_file, do_nml_term, &
                              error_handler, finalize_utilities, E_ERR, E_MSG,  &
                              find_namelist_in_file, check_namelist_read
 
@@ -96,7 +96,7 @@
 call check_namelist_read(iunit, io, "ncepobs_nml")
 
 ! Record the namelist values used for the run ...
-if (do_nml_file()) write(logfileunit, nml=ncepobs_nml)
+if (do_nml_file()) write(nmlfileunit, nml=ncepobs_nml)
 if (do_nml_term()) write(     *     , nml=ncepobs_nml)
 
 ! Loop through the days interested.

Modified: DART/trunk/observations/NCEP/ascii_to_obs/prepbufr_to_obs.f90
===================================================================
--- DART/trunk/observations/NCEP/ascii_to_obs/prepbufr_to_obs.f90	2016-05-31 22:15:22 UTC (rev 10331)
+++ DART/trunk/observations/NCEP/ascii_to_obs/prepbufr_to_obs.f90	2016-06-02 16:40:15 UTC (rev 10332)
@@ -11,7 +11,7 @@
                               register_module, error_handler, &
                               timestamp, is_longitude_between, &
                               initialize_utilities, register_module,            &
-                              do_output, logfileunit, do_nml_file, do_nml_term, &
+                              do_output, nmlfileunit, do_nml_file, do_nml_term, &
                               finalize_utilities, E_ERR, E_MSG,  &
                               find_namelist_in_file, check_namelist_read
 use  obs_def_mod,      only : obs_def_type, get_obs_def_time, read_obs_def, &
@@ -143,7 +143,7 @@
 call check_namelist_read(iunit, io, "prepbufr_to_obs_nml")
 
 ! Record the namelist values used for the run
-if (do_nml_file()) write(logfileunit, nml=prepbufr_to_obs_nml)
+if (do_nml_file()) write(nmlfileunit, nml=prepbufr_to_obs_nml)
 if (do_nml_term()) write(     *     , nml=prepbufr_to_obs_nml)
 
 ! set observation calendar type and start/end dates


More information about the Dart-dev mailing list