[Dart-dev] [9555] DART/trunk/models/cam/model_mod.f90: This model_mod is functionally identical to the previous commit,

[nancy at ucar.edu]

Revision: 9555
Author:   raeder
Date:     2016-01-20 14:15:48 -0700 (Wed, 20 Jan 2016)
Log Message:
-----------
This model_mod is functionally identical to the previous commit,
but has been brought into line (mostly) with the DART style guide.

Most of the changes are white space, so turning that off in xxdiff
will clarify the real differences.  
Many changes are replacement of 'dimension(...) ::' attributes with 
':: variable(...)'.
Many changes are replacment of CamelBackStyleNames with under_score_style.
There are added comments for doxygen documentation.  They start with '!>'.

The style changes also revealed a mistake in previous model_mods.
The grid_1d_type P0 (0-D reference pressure in CAM) was using an 
incorrect dimension ID when being written from nc_write_model_atts.
This should have had no impact on any assimilations.  
Despite this, an FV test shows that the Posterior_Diag files are identical
when using the previous, non-style, model_mod, and this one.  Test results
are in case FV_new_damp_defaults/archive/dart/hist/Post_merge_{base,style},
and others generated by Hendricks.

This is the version which should be used as the basis for splitting 
models/cam into specialized versions.  The beautification work of the 
undertaker is done.

Modified Paths:
--------------
    DART/trunk/models/cam/model_mod.f90

-------------- next part --------------
Modified: DART/trunk/models/cam/model_mod.f90
===================================================================
--- DART/trunk/models/cam/model_mod.f90	2016-01-20 17:29:40 UTC (rev 9554)
+++ DART/trunk/models/cam/model_mod.f90	2016-01-20 21:15:48 UTC (rev 9555)
@@ -6914,7 +6914,6 @@
 if (l_rectang) then
 
    call interp_lonlat(vec, base_obs_loc, KIND_SURFACE_ELEVATION, h_surf, vstatus)
-   ! newFIXME; put Fail message other places like this   ! Failure; istatus = 1
    if (vstatus == 1) then
       write(string1,'(A,1p3F12.6)') 'surface elevation could not be interpolated in interp_lonlat at ', &
                            lon_lat_lev