[Dart-dev] [6849] DART/trunk/models/wrf: remove the 4 obsolete namelist items ( which have been

nancy at ucar.edu nancy at ucar.edu
Tue Mar 11 15:51:32 MDT 2014


Revision: 6849
Author:   nancy
Date:     2014-03-11 15:51:32 -0600 (Tue, 11 Mar 2014)
Log Message:
-----------
remove the 4 obsolete namelist items (which have been
ignored forever), and update the namelists and docs
to match.

Modified Paths:
--------------
    DART/trunk/models/wrf/model_mod.f90
    DART/trunk/models/wrf/model_mod.html
    DART/trunk/models/wrf/model_mod.nml

-------------- next part --------------
Modified: DART/trunk/models/wrf/model_mod.f90
===================================================================
--- DART/trunk/models/wrf/model_mod.f90	2014-03-10 15:01:49 UTC (rev 6848)
+++ DART/trunk/models/wrf/model_mod.f90	2014-03-11 21:51:32 UTC (rev 6849)
@@ -194,24 +194,12 @@
 !JPH -- single column model flag 
 logical :: scm        = .false.    ! using the single column model
 
-! obsolete items; ignored by this code. 
-! non-backwards-compatible change. should be removed, 
-! but see note below about namelist.
-integer :: num_moist_vars
-logical :: surf_obs, soil_data, h_diab
-
-! adv_mod_command moved to dart_to_wrf namelist; ignored here.
-character(len = 72) :: adv_mod_command = ''
-
 ! num_moist_vars, surf_obs, soil_data, h_diab, and adv_mod_command
-! are IGNORED no matter what their settings in the namelist are.
-! they are obsolete, but removing them here will cause a fatal error
-! until users remove them from their input.nml files as well.
-namelist /model_nml/ output_state_vector, num_moist_vars, &
-                     num_domains, calendar_type, surf_obs, soil_data, h_diab, &
+! were removed from the namelist after being deprecated for a long time.
+namelist /model_nml/ output_state_vector, num_domains, calendar_type, &
                      default_state_variables, wrf_state_variables, &
                      wrf_state_bounds, sfc_elev_max_diff, &
-                     adv_mod_command, assimilation_period_seconds, &
+                     assimilation_period_seconds, &
                      allow_obs_below_vol, vert_localization_coord, &
                      center_search_half_length, center_spline_grid_scale, &
                      circulation_pres_level, circulation_radius, polar, &
@@ -351,14 +339,6 @@
 if (do_nml_file()) write(nmlfileunit, nml=model_nml)
 if (do_nml_term()) write(     *     , nml=model_nml)
 
-! Temporary warning until this namelist item is removed.
-if (adv_mod_command /= '') then
-   msgstring2 = "Set the model advance command in the &dart_to_wrf_nml namelist"
-   call error_handler(E_MSG, 'static_init_model:', &
-         "WARNING: adv_mod_command ignored in &model_mod namelist", &
-          text2=msgstring2)
-endif
-
 allocate(wrf%dom(num_domains))
 
 ! get default state variable table if asked

Modified: DART/trunk/models/wrf/model_mod.html
===================================================================
--- DART/trunk/models/wrf/model_mod.html	2014-03-10 15:01:49 UTC (rev 6848)
+++ DART/trunk/models/wrf/model_mod.html	2014-03-11 21:51:32 UTC (rev 6849)
@@ -121,12 +121,7 @@
    num_domains                 = 1,
    output_state_vector         = .false.,
    calendar_type               = 3,
-   num_moist_vars              = 3,
-   surf_obs                    = .true.,
-   soil_data                   = .true.,
-   h_diab                      = .false.,
    assimilation_period_seconds = 21600,
-   adv_mod_command             = './wrf.exe',
    allow_obs_below_vol         = .false.,
    vert_localization_coord     = 3,
    center_search_half_length   = 500000.,
@@ -374,32 +369,56 @@
        </UL>
 </TD></TR>
     
+</TBODY> 
+</TABLE>
+</div>
+
+<P> The following items used to be in the WRF namelist
+but have been removed.  The first 4 are no longer needed,
+and the last one was moved to
+<a href="WRF_DART_utilities/dart_to_wrf.html#Namelist">&amp;dart_to_wrf_nml</a>
+in 2010.
+In the Lanai release having these values in the namelist
+does not cause a fatal error, but more recent versions of
+the code will fail if any of these values are specified.
+Remove them from your namelist to avoid errors.
+</P>
+
+<div>
+<TABLE border=0 cellpadding=10 width=100% summary='namelist description'>
+<THEAD align=left>
+<TR><TH> Item </TH>
+    <TH> Type </TH>
+    <TH> Description </TH> </TR>
+</THEAD>
+
+<TBODY valign=top>
+
 <TR><TD> surf_obs </TD>
     <TD> logical </TD>
-    <TD>DEPRECATED -- has no effect on the code and will be removed.
+    <TD>OBSOLETE -- now an error to specify this.
 </TD></TR>
 
 <TR><TD> soil_data </TD>
     <TD> logical </TD>
-    <TD>DEPRECATED -- has no effect on the code and will be removed.
+    <TD>OBSOLETE -- now an error to specify this.
 </TD></TR>
 
 <TR><TD> h_diab </TD>
     <TD> logical </TD>
-    <TD>DEPRECATED -- has no effect on the code and will be removed.
+    <TD>OBSOLETE -- now an error to specify this.
 </TD></TR>
 
 <TR><TD> num_moist_vars </TD>
     <TD> integer </TD>
-    <TD>DEPRECATED -- has no effect on the code and will be removed.
+    <TD>OBSOLETE -- now an error to specify this.
 </TD></TR>
 
 <TR><TD> adv_mod_command </TD>
     <TD> character(len=32) </TD>
-    <TD>DEPRECATED -- A variable with the same name has moved to the 
-<a href="WRF_DART_utilities/dart_to_wrf.html#Namelist">&amp;dart_to_wrf</a>
-namelist and does the same function from there.  This one has no effect on
-the code and will be removed soon.  
+    <TD>OBSOLETE -- This variable was moved to the 
+<a href="WRF_DART_utilities/dart_to_wrf.html#Namelist">&amp;dart_to_wrf_nml</a>
+namelist. Now an error to specify this here.
 </TD></TR>
 
 </TBODY> 

Modified: DART/trunk/models/wrf/model_mod.nml
===================================================================
--- DART/trunk/models/wrf/model_mod.nml	2014-03-10 15:01:49 UTC (rev 6848)
+++ DART/trunk/models/wrf/model_mod.nml	2014-03-11 21:51:32 UTC (rev 6849)
@@ -49,12 +49,7 @@
    num_domains                 = 1,
    output_state_vector         = .false.,
    calendar_type               = 3,
-   num_moist_vars              = 3,
-   surf_obs                    = .true.,
-   soil_data                   = .true.,
-   h_diab                      = .false.,
    assimilation_period_seconds = 21600,
-   adv_mod_command             = './wrf.exe',
    allow_obs_below_vol         = .false.,
    vert_localization_coord     = 3,
    center_search_half_length   = 500000.,


More information about the Dart-dev mailing list