[Dart-dev] [6191] DART/branches/development/observations: Enhanced the buildall. csh script to build every quickbuild.csh it

nancy at ucar.edu nancy at ucar.edu
Wed May 29 16:37:30 MDT 2013


Revision: 6191
Author:   thoar
Date:     2013-05-29 16:37:30 -0600 (Wed, 29 May 2013)
Log Message:
-----------
Enhanced the buildall.csh script to build every quickbuild.csh it
can find. Removed unused variables identified by the Intel compiler
on yellowstone: ifort (IFORT) 12.1.5 20120612

Modified Paths:
--------------
    DART/branches/development/observations/MADIS/convert_madis_profiler.f90
    DART/branches/development/observations/MADIS/convert_madis_satwnd.f90
    DART/branches/development/observations/MIDAS/MIDAS_to_obs.f90
    DART/branches/development/observations/NCEP/ascii_to_obs/real_obs_mod.f90
    DART/branches/development/observations/SSEC/convert_ssec_satwnd.f90
    DART/branches/development/observations/WOD/wod_read_routines.f90
    DART/branches/development/observations/buildall.csh
    DART/branches/development/observations/gps/convert_cosmic_gps_cdf.f90
    DART/branches/development/observations/snow/snow_to_obs.f90
    DART/branches/development/observations/text/text_to_obs.f90

-------------- next part --------------
Modified: DART/branches/development/observations/MADIS/convert_madis_profiler.f90
===================================================================
--- DART/branches/development/observations/MADIS/convert_madis_profiler.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/MADIS/convert_madis_profiler.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -60,7 +60,7 @@
                       num_qc     = 1        ! number of QC entries
 
 
-integer  :: ncid, nsta, nlev, n, i, oday, osec, nused, j, k, index
+integer  :: ncid, nsta, nlev, n, i, oday, osec, nused, k, index
 logical  :: file_exist, first_obs
 real(r8) :: uwnd_miss, vwnd_miss
 

Modified: DART/branches/development/observations/MADIS/convert_madis_satwnd.f90
===================================================================
--- DART/branches/development/observations/MADIS/convert_madis_satwnd.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/MADIS/convert_madis_satwnd.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -66,21 +66,17 @@
                       num_qc     = 1        ! number of QC entries
 
 
-logical :: iruse, visuse, wvuse, swiruse, allbands
+logical :: iruse, visuse, wvuse, allbands
 
-character (len=5)   :: rtype
 integer  :: ncid, nobs, n, i, oday, osec, nused
 logical  :: file_exist, first_obs
 real(r8) :: wdir_miss, wspd_miss
 integer  :: band_miss
 
 ! FIXME:from ssec version
-!logical :: iruse, visuse, wvuse, swiruse, file_exist, qifile, eefile, &
-!           userfqc, useqiqc, useeeqc
+!logical :: iruse, visuse, wvuse, file_exist, qifile, eefile
 
-integer :: iyear, imonth, iday, ihour, imin, isec, qctype
-real(r8) :: uwnd, vwnd, oerr, &
-            qc, qcthresh, rfqc, qiqc, eeqc
+real(r8) :: uwnd, vwnd, oerr, qc
 ! end FIXME
 
 

Modified: DART/branches/development/observations/MIDAS/MIDAS_to_obs.f90
===================================================================
--- DART/branches/development/observations/MIDAS/MIDAS_to_obs.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/MIDAS/MIDAS_to_obs.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -4,12 +4,6 @@
 
 program MIDAS_to_obs
 
-! <next few lines under version control, do not edit>
-! $URL$
-! $Id$
-! $Revision$
-! $Date$
-
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !
 ! MIDAS_to_obs - reads the MIDAS data as created by Alex in a netCDF file
@@ -19,7 +13,7 @@
 use          types_mod, only : r8, MISSING_R8, metadatalength
 
 use      utilities_mod, only : initialize_utilities, finalize_utilities, &
-                               register_module, error_handler, E_ERR, &
+                               register_module, error_handler, E_ERR, E_MSG, &
                                do_nml_file, do_nml_term, &
                                check_namelist_read, find_namelist_in_file, &
                                nmlfileunit, file_exist, nc_check
@@ -173,7 +167,8 @@
    if (verbose) print *, 'writing obs_seq, obs_count = ', get_num_obs(obs_seq)
    call write_obs_seq(obs_seq, obs_out_file)
 else
-   call error_handler(E_MSG,'lkljlkjkj'
+   write(string1,*)'There are no observations to write.'
+   call error_handler(E_MSG,'MIDAS_to_obs',string1,source,revision,revdate)
 endif
 
 ! end of main program
@@ -323,3 +318,9 @@
 
 end program MIDAS_to_obs
 
+! <next few lines under version control, do not edit>
+! $URL$
+! $Id$
+! $Revision$
+! $Date$
+

Modified: DART/branches/development/observations/NCEP/ascii_to_obs/real_obs_mod.f90
===================================================================
--- DART/branches/development/observations/NCEP/ascii_to_obs/real_obs_mod.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/NCEP/ascii_to_obs/real_obs_mod.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -122,7 +122,7 @@
 integer :: day0, sec0
 integer :: hour, imin, sec
 integer :: obs_num, calender_type
-type(time_type) :: current_day, next_day, time_obs, prev_time
+type(time_type) :: current_day, time_obs, prev_time
 
 integer, parameter :: num_fail_kinds = 6
 integer :: iskip(num_fail_kinds)
@@ -143,8 +143,8 @@
 
 integer :: obs_unit
 integer :: obs_prof, obs_kind, obs_kind_gen, which_vert, iqc, obstype, pc
-real (r8) :: obs_err, lon, lat, lev, zob, time, pre_time, rcount, zob2
-real (r8) :: vloc, obs_value, aqc, var2
+real (r8) :: obs_err, lon, lat, lev, zob, time, rcount, zob2
+real (r8) :: vloc, obs_value, aqc
 
 real (r8) :: bin_beg, bin_end
 

Modified: DART/branches/development/observations/SSEC/convert_ssec_satwnd.f90
===================================================================
--- DART/branches/development/observations/SSEC/convert_ssec_satwnd.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/SSEC/convert_ssec_satwnd.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -54,7 +54,7 @@
            userfqc, useqiqc, useeeqc, first_obs
 
 integer :: in_unit, i, oday, osec, nused, iyear, imonth, iday, ihour, & 
-           imin, isec, qctype
+           imin, qctype
 real(r8) :: lat, lon, pres, wdir, wspd, uwnd, vwnd, oerr, latu(nmaxwnd), &
             lonu(nmaxwnd), prsu(nmaxwnd), qc, qcthresh, rfqc, qiqc, eeqc
 

Modified: DART/branches/development/observations/WOD/wod_read_routines.f90
===================================================================
--- DART/branches/development/observations/WOD/wod_read_routines.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/WOD/wod_read_routines.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -286,7 +286,7 @@
       !dimension jtottax(maxtcode,maxtax),itaxerr(maxtcode,maxtax)
       !dimension itaxorigerr(maxtcode,maxtax)
 
-      integer :: n, nn, n0, n1, n2, i, j, k, ij, castid
+      integer :: n, nn, n0, n2, i, castid
       integer :: nbio, inc, nchar, nlines, istartc, icruise, npinf
       integer :: npi, inchad, ica, icn, ns, insec, inbio, nbothtot, itaxtot
 

Modified: DART/branches/development/observations/buildall.csh
===================================================================
--- DART/branches/development/observations/buildall.csh	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/buildall.csh	2013-05-29 22:37:30 UTC (rev 6191)
@@ -11,14 +11,49 @@
 
 set startdir=`pwd`
 
-foreach dir ( */oned */threed_sphere */*/work */work )
- cd $dir
- echo building in $dir
- echo
+foreach project ( `find . -name quickbuild.csh -print` )
 
- ./quickbuild.csh || echo ERROR unsuccessful build in $dir
+   set dir = $project:h
+   set FAILURE = 0
 
- cd $startdir
+   cd $dir
+   echo
+   echo building in $dir
+
+   switch ("$dir")
+
+      case */var/*
+         echo "expected to fail unless you have the WRF code in-situ."
+      breaksw
+         
+      case *AIRS*
+         ./quickbuild.csh
+         echo "AIRS build is expected to fail due to dependency on hdfeos libs,"
+         echo "not required to be part of the standard DART environment."
+      breaksw
+         
+      case *quikscat*
+         ./quickbuild.csh
+         echo "quikscat build is expected to fail due to dependency on mfhdf libs,"
+         echo "not required to be part of the standard DART environment."
+      breaksw
+         
+      default:
+         ./quickbuild.csh || set FAILURE = 1
+      breaksw
+         
+   endsw
+
+   if ( $FAILURE != 0 ) then
+      echo
+      echo "ERROR unsuccessful build in $dir"
+      echo "ERROR unsuccessful build in $dir"
+      echo "ERROR unsuccessful build in $dir"
+      echo
+#     exit -1
+   endif
+
+   cd $startdir
 end
 
 exit 0

Modified: DART/branches/development/observations/gps/convert_cosmic_gps_cdf.f90
===================================================================
--- DART/branches/development/observations/gps/convert_cosmic_gps_cdf.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/gps/convert_cosmic_gps_cdf.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -58,15 +58,14 @@
 
 character (len=129) :: msgstring, next_infile
 character (len=80)  :: name
-character (len=19)  :: datestr
 character (len=6)   :: subset
-integer :: rcode, ncid, varid, nlevels, k, nfiles, num_new_obs, oday, osec, &
+integer :: ncid, varid, nlevels, k, nfiles, num_new_obs, oday, osec, &
            iyear, imonth, iday, ihour, imin, isec, glat, glon, zloc, obs_num, &
            io, iunit, nobs, filenum, dummy
 logical :: file_exist, first_obs, did_obs, from_list = .false.
 real(r8) :: hght_miss, refr_miss, azim_miss, oerr,               & 
             qc, lato, lono, hghto, refro, azimo, wght, nx, ny,   & 
-            nz, ds, htop, rfict, obsval, phs, obs_val(1), qc_val(1)
+            nz, rfict, obsval, phs, obs_val(1), qc_val(1)
 
 real(r8), allocatable :: lat(:), lon(:), hght(:), refr(:), azim(:), & 
                          hghtp(:), refrp(:)
@@ -74,7 +73,7 @@
 type(obs_def_type)      :: obs_def
 type(obs_sequence_type) :: obs_seq
 type(obs_type)          :: obs, prev_obs
-type(time_type)         :: time_obs, time_anal, prev_time
+type(time_type)         :: time_obs, prev_time
 
 !------------------------------------------------------------------------
 !  Declare namelist parameters

Modified: DART/branches/development/observations/snow/snow_to_obs.f90
===================================================================
--- DART/branches/development/observations/snow/snow_to_obs.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/snow/snow_to_obs.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -40,13 +40,13 @@
 
 character(len=64), parameter :: obs_out_file    = 'obs_seq.out'
 
-integer :: n, i, oday, osec, rcio, iunit, otype, io
+integer :: oday, osec, rcio, iunit, io
 integer :: num_copies, num_qc, max_obs, ix, iy
            
 logical  :: file_exist, first_obs
 
-real(r8) :: temp, terr, qc, wdir, wspeed, werr
-real(r8) :: lat, lon, vert, uwnd, uerr, vwnd, verr
+real(r8) :: terr, qc
+real(r8) :: lat, lon, vert
 real(r8) :: dlon, dlat
 real(r8), allocatable :: coverage(:)
 

Modified: DART/branches/development/observations/text/text_to_obs.f90
===================================================================
--- DART/branches/development/observations/text/text_to_obs.f90	2013-05-29 22:33:51 UTC (rev 6190)
+++ DART/branches/development/observations/text/text_to_obs.f90	2013-05-29 22:37:30 UTC (rev 6191)
@@ -43,7 +43,7 @@
 
 character (len=129) :: input_line
 
-integer :: n, i, oday, osec, rcio, iunit, otype
+integer :: oday, osec, rcio, iunit, otype
 integer :: year, month, day, hour, minute, second
 integer :: num_copies, num_qc, max_obs
            


More information about the Dart-dev mailing list