[Dart-dev] [4314] DART/trunk/models/template/model_mod.f90: Two birds with one stone; don't overwrite pert_state with missing_r8

nancy at ucar.edu nancy at ucar.edu
Fri Mar 12 13:13:59 MST 2010


Revision: 4314
Author:   nancy
Date:     2010-03-12 13:13:59 -0700 (Fri, 12 Mar 2010)
Log Message:
-----------
Two birds with one stone; don't overwrite pert_state with missing_r8
because that's bad, and by using 'state' you avoid the unused variable
compiler warning.  (This usage didn't hurt any code because a utility
using the template model_mod better just be using it to satisfy external
symbols so it compiles and not because it is expected to do anything real.)

Modified Paths:
--------------
    DART/trunk/models/template/model_mod.f90

-------------- next part --------------
Modified: DART/trunk/models/template/model_mod.f90
===================================================================
--- DART/trunk/models/template/model_mod.f90	2010-03-12 20:09:44 UTC (rev 4313)
+++ DART/trunk/models/template/model_mod.f90	2010-03-12 20:13:59 UTC (rev 4314)
@@ -574,13 +574,15 @@
 ! may do so by adding an O(0.1) magnitude perturbation to each
 ! model state variable independently. The interf_provided argument
 ! should be returned as .true. if the model wants to do its own
-! perturbing of states.
+! perturbing of states.  The returned pert_state should in any
+! case be valid, since it will be read by filter even if 
+! interf_provided is .false.
 
 real(r8), intent(in)  :: state(:)
 real(r8), intent(out) :: pert_state(:)
 logical,  intent(out) :: interf_provided
 
-pert_state      = MISSING_R8
+pert_state      = state
 interf_provided = .false.
 
 end subroutine pert_model_state


More information about the Dart-dev mailing list