[Dart-dev] [4138] DART/trunk/diagnostics/threed_sphere: Made the input_qc_threshold in code match both the new

nancy at ucar.edu nancy at ucar.edu
Fri Nov 6 13:13:09 MST 2009


Revision: 4138
Author:   nancy
Date:     2009-11-06 13:13:09 -0700 (Fri, 06 Nov 2009)
Log Message:
-----------
Made the input_qc_threshold in code match both the new
filter behavior, and also the existing obs_diag documentation.
Changed the defaults from 4 to 3 so the behavior remains
the same for now.

Modified Paths:
--------------
    DART/trunk/diagnostics/threed_sphere/obs_diag.f90
    DART/trunk/diagnostics/threed_sphere/obs_diag.html
    DART/trunk/diagnostics/threed_sphere/obs_diag.nml

-------------- next part --------------
Modified: DART/trunk/diagnostics/threed_sphere/obs_diag.f90
===================================================================
--- DART/trunk/diagnostics/threed_sphere/obs_diag.f90	2009-11-06 20:07:04 UTC (rev 4137)
+++ DART/trunk/diagnostics/threed_sphere/obs_diag.f90	2009-11-06 20:13:09 UTC (rev 4138)
@@ -180,17 +180,18 @@
 type(location_type), dimension(MaxRegions) :: min_loc, max_loc
 
 real(r8):: rat_cri               = 5000.0_r8 ! QC ratio
-real(r8):: input_qc_threshold    = 4.0_r8    ! maximum NCEP QC factor
+real(r8):: input_qc_threshold    = 3.0_r8    ! maximum NCEP QC factor
 logical :: print_mismatched_locs = .false.
 logical :: print_obs_locations   = .false.
 logical :: verbose               = .false.
 
-namelist /obs_diag_nml/ obs_sequence_name, obs_sequence_list, &
-                       first_bin_center, last_bin_center, &
+namelist /obs_diag_nml/ obs_sequence_name, obs_sequence_list,                 &
+                       first_bin_center, last_bin_center,                     &
                        bin_separation, bin_width, time_to_skip, max_num_bins, &
-                       plevel, hlevel, mlevel, rat_cri, input_qc_threshold, &
-                       Nregions, lonlim1, lonlim2, latlim1, latlim2, &
-                       reg_names, print_mismatched_locs, print_obs_locations, verbose
+                       plevel, hlevel, mlevel, rat_cri, input_qc_threshold,   &
+                       Nregions, lonlim1, lonlim2, latlim1, latlim2,          &
+                       reg_names, print_mismatched_locs, print_obs_locations, &
+                       obs_sequence_list, verbose
 
 !-----------------------------------------------------------------------
 ! Variables used to accumulate the statistics.
@@ -973,7 +974,7 @@
             !-----------------------------------------------------------
 
             if( qc_index > 0 ) then
-               if (qc(qc_index) >= input_qc_threshold ) then
+               if (qc(qc_index) > input_qc_threshold ) then
                call IPE(guess%NbadQC(iepoch,level_index,iregion,flavor), 1)
                call IPE(analy%NbadQC(iepoch,level_index,iregion,flavor), 1)
                endif
@@ -1062,7 +1063,7 @@
             !-----------------------------------------------------------
 
             if( qc_index > 0 ) then
-               if (qc(qc_index) >= input_qc_threshold ) then
+               if (qc(qc_index) > input_qc_threshold ) then
                call IPE(guessAVG%NbadQC(level_index,iregion,flavor), 1)
                call IPE(analyAVG%NbadQC(level_index,iregion,flavor), 1)
                endif

Modified: DART/trunk/diagnostics/threed_sphere/obs_diag.html
===================================================================
--- DART/trunk/diagnostics/threed_sphere/obs_diag.html	2009-11-06 20:07:04 UTC (rev 4137)
+++ DART/trunk/diagnostics/threed_sphere/obs_diag.html	2009-11-06 20:13:09 UTC (rev 4138)
@@ -246,7 +246,7 @@
 
 <P>
    Optional namelist interface
-   <A HREF="#Namelist"><em class=code>&#38;obs_diag_nml</em></A>
+   <A HREF="#Namelist"><em class=code>&amp;obs_diag_nml</em></A>
    may be read from file <em class=file>input.nml</em>.
 </P>
 
@@ -278,13 +278,14 @@
 <BR><HR><BR>
 <H2>NAMELIST</H2>
 <P>We adhere to the F90 standard of starting a namelist with an 
-   ampersand '&#38;' and terminating with a slash '/'.
+   ampersand '&amp;' and terminating with a slash '/'.
    <div class=namelist><pre>
-   <em class=call>namelist / obs_diag_nml / </em> &#38;
-      obs_sequence_name, obs_sequence_list, first_bin_center, last_bin_center, &#38;
-      bin_separation, bin_width, time_to_skip, max_num_bins, &#38;
-      plevel, hlevel, mlevel, <em class=removed>obs_select</em>, rat_cri, input_qc_threshold, &#38;
-      Nregions, lonlim1, lonlim2, latlim1, latlim2, &#38;
+   <em class=call>namelist / obs_diag_nml / </em> 
+      obs_sequence_name, obs_sequence_list, first_bin_center, last_bin_center, 
+      bin_separation, bin_width, time_to_skip, max_num_bins, 
+      plevel, hlevel, mlevel, <em class=removed>obs_select</em>, 
+      rat_cri, input_qc_threshold, 
+      Nregions, lonlim1, lonlim2, latlim1, latlim2, 
       reg_names, print_mismatched_locs, print_obs_locations, verbose
    </pre></div>
 </P>
@@ -326,6 +327,7 @@
 	    interest.<BR>e.g. 'obsdir_001/obs_seq.final' will cause
 	    <em class="program">obs_diag</em> to look for
 	    'obsdir_002/obs_seq.final', and so on.<BR>
+            If this is set, 'obs_sequence_list' must be set to ''.
 	    Default 'obs_seq.final'</TD></TR>  
 
 <TR><!--contents--><TD valign=top>   obs_sequence_list </TD>
@@ -335,6 +337,7 @@
             If this is specified, 'obs_sequence_name' must be set to ''. 
             Can be created by any method, including sending the output
             of the 'ls' command to a file, a text editor, or another program.
+            If this is set, 'obs_sequence_name' must be set to ''.
 	    <BR>
 	    Default '' - an empty string.</TD></TR>  
 

Modified: DART/trunk/diagnostics/threed_sphere/obs_diag.nml
===================================================================
--- DART/trunk/diagnostics/threed_sphere/obs_diag.nml	2009-11-06 20:07:04 UTC (rev 4137)
+++ DART/trunk/diagnostics/threed_sphere/obs_diag.nml	2009-11-06 20:13:09 UTC (rev 4138)
@@ -18,7 +18,7 @@
    time_to_skip     =     0, 0, 0, 6, 0, 0 ,
    max_num_bins     = 1000,
    rat_cri            = 3.0,
-   input_qc_threshold = 4.0,
+   input_qc_threshold = 3.0,
    Nregions   = 4,
    lonlim1    =   0.0,   0.0,   0.0, 235.0,
    lonlim2    = 360.0, 360.0, 360.0, 295.0,


More information about the Dart-dev mailing list