[Dart-dev] [3539] DART/trunk/diagnostics/threed_sphere/obs_diag.f90: Fix for rare case that the U wind component has a bad DART QC, but the

[nancy at ucar.edu]

An HTML attachment was scrubbed...
URL: http://mailman.ucar.edu/pipermail/dart-dev/attachments/20080815/c875be59/attachment.html
-------------- next part --------------
Modified: DART/trunk/diagnostics/threed_sphere/obs_diag.f90
===================================================================
--- DART/trunk/diagnostics/threed_sphere/obs_diag.f90	2008-08-14 23:18:53 UTC (rev 3538)
+++ DART/trunk/diagnostics/threed_sphere/obs_diag.f90	2008-08-15 16:07:46 UTC (rev 3539)
@@ -824,12 +824,16 @@
          ! integer, parameter  :: QC_MAX_PRIOR     = 3
          ! integer, parameter  :: QC_MAX_POSTERIOR = 1
 
+         ! debug section for strange looking observations:
          if ( 1 == 2 ) then
          call get_obs_values(observation, copyvals)
-     !   if (any(copyvals < -87.0) .and. ( qc_integer < (QC_MAX_PRIOR+1) ) ) then
-         if ( obsindex == 311 ) then
+     ! add your own if test here and turn 1 == 2 into 1 == 1 above:
+     !   if ( obsindex == 311 ) then
+     !   if (any(copyvals < -87.0).and.( qc_integer < (QC_MAX_PRIOR+1) ) ) then
+     !   if (abs(prior_mean(1)) > 1000 .and. qc_integer < 4) then
+         if (.true.) then
               write(*,*)
-              write(*,*)'Observation index 311 is ',keys(obsindex),' and has:'
+              write(*,*)'Observation index is ',keys(obsindex),' and has:'
               write(*,*)'flavor                 is',flavor
               write(*,*)'obs              value is',obs(1)
               write(*,*)'prior_mean       value is',prior_mean(1)
@@ -1010,7 +1014,8 @@
                      call IPE(analy%NbadIZ(iepoch,level_index,iregion,wflavor), 1)
                   endif
 
-                  call Bin4D(qc_integer, iepoch, level_index, iregion, wflavor, &
+                  call Bin4D(maxval( (/qc_integer, U_qc/) ), &
+                       iepoch, level_index, iregion, wflavor, &
                        obs(1),  obs_err_var,   pr_mean,   pr_sprd,   po_mean,   po_sprd,  &
                        U_obs, U_obs_err_var, U_pr_mean, U_pr_sprd, U_po_mean, U_po_sprd   )
                endif